New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes needed to support line directives #919
Changes needed to support line directives #919
Conversation
An extra blank line after a directive throws off the numbering. The m-CORE.setting file is no longer seen in a backtrace, so we need another way of determining if we are in the settings. This isn't a great solution, but should work for now.
IMO just checking the path for I ran this command on my box and it got 681 matches, only 594 of which are in my
Looking at changes in https://github.com/perl6/nqp/pull/319/files... can't we just add some sort of special prefix to core files and filter them out that way instead? As in, if it were CORE.setting and now it's src/core/whaver, sounds like we can use arbitrary data in there... |
This one?
TBH, I'm not a fan of "for now" solutions. We're not in a rush; why not do it right the first time around? In the NQP PR this line just finds the filename that the gen-cat script makes, right?:
So what if we change the gen-cat script line 23 from Then instead of Is there a problem with this approach? |
I don't really have a problem with that approach. However, you'd need to remove the 'Rakudo::Internals/' when printing the backtrace to reflect the actual file paths. @jnthn didn't like modifying the values in Backtrace.pm (which my first attempt at implementing this did), but maybe simply removing a static string would be fine. |
I would be fine with leaving |
I'm n favour of adding a marker, but would be against using Rakudo::Internals, to prevent confusion with the Rakudo/Internals.pm file. How about just prefixing it with SETTING:: ? That would be sort of appropriate anyway :) and leave it in printing |
Sounds good to me. |
Use the mark added to tools/build/gen-cat.nqp
Change made, @lizmat++, @zoffixznet++ |
Thanks a lot. |
An extra blank line after a directive throws off the numbering.
The m-CORE.setting file is no longer seen in a backtrace, so we need
another way of determining if we are in the settings. This isn't a
great solution, but should work for now.
Requires Raku/nqp#319
With the NQP PR, passes
make spectest