This repository has been archived by the owner on Dec 28, 2020. It is now read-only.
Make channels buffered to prevent goroutines leak. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users may ignore done message. Also, functions which runs two goroutines that writes to one channel will always produce a leak. Killable must send kill message if user didn't.
| @@ -69,7 +69,7 @@ func Every(dur time.Duration, fn func()) { | |||
| // channel if timeout occurs. | |||
| // TODO: cancel if timeout occurs | |||
| func Timeout(duration time.Duration, fn func()) (done <-chan bool) { | |||
| ch := make(chan bool) | |||
| ch := make(chan bool, 2) | |||
There was a problem hiding this comment.
This channel never receives two messages, should we keep the buffer size 1 as well?
|
@rakyll |
|
@bredov, sorry, channel receives two messages. It's an implementation problem, I'll provide a fix to ignore the secondary signal. Merging the PR, thanks! |
rakyll
pushed a commit
that referenced
this pull request
Jan 23, 2014
Make channels buffered to prevent goroutines leak.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may ignore done message. Also, functions which runs two goroutines that writes to one channel will always produce a leak.
Killable must send kill message if user didn't.