Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Issue priorities reversed and off-by-one #9

Closed
fnilsen opened this Issue Oct 16, 2011 · 1 comment

Comments

Projects
None yet
2 participants

fnilsen commented Oct 16, 2011

I believe the issue priority hash map is reversed and off by one:

PRIORITY_MAPPING = {
     "P1" => priorities[1], # low
     "P2" => priorities[2], # normal
     "P3" => priorities[3], # high
     "P4" => priorities[4], # urgent
     "P5" => priorities[5]  # immediate
}

The priorities array starts at 0. As for reversed, we have always used P1 == highest priority - I'm not sure if there's an official Bugzilla convention for this, but I thought I'd mention it anyway.

For our migration, I had to change the mapping as follows:

PRIORITY_MAPPING = {
     "P5" => priorities[0], # low
     "P4" => priorities[1], # normal
     "P3" => priorities[2], # high
     "P2" => priorities[3], # urgent
     "P1" => priorities[4]  # immediate
 }

ralli added a commit that referenced this issue Nov 18, 2011

fixed bug #9 reported by "fnilsen"
reversed the issue prioritiesm which where reverted
(lowest priority in bugzilla became the highest priority in redmine)
Owner

ralli commented Nov 18, 2011

Thank you for the bug report. You are absolutely right. i had to revert the
priorities.

@ralli ralli closed this Nov 18, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment