Move factory.stopTrying() from Component.startService to Component.stopService method#2
Closed
allait wants to merge 1 commit into
Closed
Move factory.stopTrying() from Component.startService to Component.stopService method#2allait wants to merge 1 commit into
allait wants to merge 1 commit into
Conversation
Calling factory.stopTrying() from Component.starService method prevented component from retrying to establish connection if first attempt (triggered by .serviceStart) failed.
Owner
|
This was fixed in 37b7653, along with tests. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
factory.stopTrying()fromComponent.startServicemethod prevented component from retrying to establish connection if first attempt (triggered by.serviceStart) failed. Component would try to reestablish connection if the initial one was lost though.I assume
stopTryingcall is a mistake, sinceXMPPClientimplementsstartServiceandstopServicemethods in a similar way, but callsstopTryingfromstopService, as expected. Am I missing something?