New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When you pass a string to R.test instead of a regex, it always returns true #1413

Closed
albrow opened this Issue Sep 28, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@albrow

albrow commented Sep 28, 2015

The following code returns true:

R.test('foo', 'bar')

Here it is in the repl.

This seems like a pretty easy mistake to make, and I think the appropriate behavior is to throw an exception and point out that the first argument is not the correct type.

@davidchambers

This comment has been minimized.

Member

davidchambers commented Sep 28, 2015

Are you happy for us to check the type of the first argument, @CrossEye?

@CrossEye

This comment has been minimized.

Member

CrossEye commented Sep 29, 2015

Not really, but I can't think of anything better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment