separate R.where into two simpler functions: R.where and R.whereEq #1036

davidchambers · 2015-04-20T16:55:39Z

This is the alternative to #1034. If we decide we want both functions we need to decide what to name them. :)

davidchambers · 2015-04-20T16:56:38Z

test/where.js

@@ -50,17 +27,13 @@ describe('where', function() {
  });

  it('is false if the test object is null-ish', function() {


I'd love to remove this special case.

buzzdecafe · 2015-04-20T23:35:33Z

IMO where is about specifying an interface that the input object must satisfy, not that the object's individual properties must satisfy in isolation.

megawac · 2015-04-21T01:50:42Z

I'm fine with this as long as whereEq is included

whereEq = compose(where, mapObject(eq))

CrossEye · 2015-04-21T01:55:10Z

Damn, it hadn't hit me how straightforward that conversion was:

whereEq = compose(where, mapObject(eq))

Nice.

davidchambers · 2015-04-23T22:44:37Z

Shall I add R.whereEq?

CrossEye · 2015-04-24T02:09:39Z

I could be happy with this version of where alongside a whereEq. But I believe @buzzdecafe still might have some reservations about it.

buzzdecafe · 2015-04-24T12:47:53Z

not reservations. just not seeing the point particularly.

CrossEye · 2015-04-24T20:24:17Z

I say yes, then. Two simple functions beat one complex function hands-down.

davidchambers · 2015-05-04T00:47:43Z

I've added R.whereEq.

davidchambers · 2015-05-04T00:48:24Z

src/whereEq.js

+ * spec's own properties, accessing that property of the object gives the same
+ * value (in `R.eq` terms) as accessing that property of the spec.
+ *
+ * `whereEq` is a specialization of [`where`](#where).


Is this valid use of the word specialization?

I would say so.

davidchambers · 2015-05-07T21:43:25Z

((:bell:)) @buzzdecafe, @CrossEye

buzzdecafe · 2015-05-07T23:42:57Z

i don't mind the complexity of the original. i don't really object to this, but it doesn't excite me either. i expect this may break a lot of stuff that uses where at present.

this is nice: return where(mapObj(eq, spec), testObj);
but i wonder how it performs? that was the reason for the nastiness of the original.

davidchambers · 2015-05-07T23:54:08Z

i expect this may break a lot of stuff that uses where at present.

Certainly. In most cases, users will need to replace R.where with R.whereEq:

-R.where({x: 1, y: 2})
+R.whereEq({x: 1, y: 2})

In each of the remaining cases, each non-function value in the spec must be wrapped with R.eq:

-R.where({x: 1, y: 2, z: R.gte(R.__, 0)})
+R.where({x: R.eq(1), y: R.eq(2), z: R.gte(R.__, 0)})

CrossEye · 2015-05-08T02:10:06Z

Sorry, I thought I'd made it clear that I was in favor of this.

I do think that sometime soon, we'll have to look at the basic implementation. If I'm not mistaken, in the Great Curry Debacle of 2014, we reset this one in such a way that it might have lost some of the benefits that had been gained by the initial manual currying we had done. This one was the function that showed us the need for changes to our old currying, and it had some interesting behavior...

separate R.where into two simpler functions: R.where and R.whereEq

megawac · 2015-05-08T14:49:17Z

Let's just make sure this is bold, highlighted, underlined in change log as
it will break a good amount of code
On May 8, 2015 10:46 AM, "Michael Hurley" notifications@github.com wrote:

Merged #1036 #1036.

—
Reply to this email directly or view it on GitHub
#1036 (comment).

buzzdecafe · 2015-05-08T14:51:37Z

yep, totally agree

buzzdecafe · 2015-05-08T22:51:47Z

not sure what to make of this: http://jsperf.com/mapobj-test

davidchambers · 2015-05-08T22:55:59Z

I could certainly get behind a more efficient implementation. It was API complexity this pull request sought to reduce.

megawac · 2015-05-09T00:12:52Z

src/where.js

-
-  return _satisfiesSpec(spec, parsedSpec, testObj);
+  for (var prop in spec) {
+    if (_has(prop, spec) && !spec[prop](testObj[prop])) {


Any reason you're not using keys here (it'd be faster)?

Sounds like a good idea to me!

davidchambers reviewed Apr 20, 2015
View reviewed changes

davidchambers force-pushed the where-pred branch from 1fc3c7b to 497119f Compare April 20, 2015 21:30

svozza mentioned this pull request Apr 21, 2015

Highland.js Integration #1037

Closed

davidchambers force-pushed the where-pred branch from 497119f to 2eb760c Compare May 4, 2015 00:46

davidchambers changed the title ~~simplify R.where~~ separate R.where into two simpler functions: R.where and R.whereEq May 4, 2015

davidchambers reviewed May 4, 2015
View reviewed changes

davidchambers force-pushed the where-pred branch from 2eb760c to df95868 Compare May 4, 2015 00:49

separate R.where into two simpler functions: R.where and R.whereEq

9e540f1

davidchambers force-pushed the where-pred branch from df95868 to 9e540f1 Compare May 4, 2015 00:50

davidchambers mentioned this pull request May 7, 2015

remove special handling of functions from R.where #1034

Closed

buzzdecafe added a commit that referenced this pull request May 8, 2015

Merge pull request #1036 from davidchambers/where-pred

75cc61b

separate R.where into two simpler functions: R.where and R.whereEq

buzzdecafe merged commit 75cc61b into ramda:master May 8, 2015

davidchambers deleted the where-pred branch May 8, 2015 16:59

megawac reviewed May 9, 2015
View reviewed changes

davidchambers mentioned this pull request May 12, 2015

0.14.0 upgrade guide #1080

Closed

CrossEye mentioned this pull request Jan 30, 2016

Implement applySpec #1592

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

separate R.where into two simpler functions: R.where and R.whereEq #1036

separate R.where into two simpler functions: R.where and R.whereEq #1036

davidchambers commented Apr 20, 2015

davidchambers Apr 20, 2015

CrossEye Apr 20, 2015

davidchambers Apr 20, 2015

buzzdecafe commented Apr 20, 2015

megawac commented Apr 21, 2015

CrossEye commented Apr 21, 2015

davidchambers commented Apr 23, 2015

CrossEye commented Apr 24, 2015

buzzdecafe commented Apr 24, 2015

CrossEye commented Apr 24, 2015

davidchambers commented May 4, 2015

davidchambers May 4, 2015

CrossEye May 4, 2015

davidchambers commented May 7, 2015

buzzdecafe commented May 7, 2015

davidchambers commented May 7, 2015

CrossEye commented May 8, 2015

megawac commented May 8, 2015

buzzdecafe commented May 8, 2015

buzzdecafe commented May 8, 2015

davidchambers commented May 8, 2015

megawac May 9, 2015

davidchambers May 9, 2015

		@@ -50,17 +27,13 @@ describe('where', function() {
		});

		it('is false if the test object is null-ish', function() {

separate R.where into two simpler functions: R.where and R.whereEq #1036

separate R.where into two simpler functions: R.where and R.whereEq #1036

Conversation

davidchambers commented Apr 20, 2015

davidchambers Apr 20, 2015

Choose a reason for hiding this comment

CrossEye Apr 20, 2015

Choose a reason for hiding this comment

davidchambers Apr 20, 2015

Choose a reason for hiding this comment

buzzdecafe commented Apr 20, 2015

megawac commented Apr 21, 2015

CrossEye commented Apr 21, 2015

davidchambers commented Apr 23, 2015

CrossEye commented Apr 24, 2015

buzzdecafe commented Apr 24, 2015

CrossEye commented Apr 24, 2015

davidchambers commented May 4, 2015

davidchambers May 4, 2015

Choose a reason for hiding this comment

CrossEye May 4, 2015

Choose a reason for hiding this comment

davidchambers commented May 7, 2015

buzzdecafe commented May 7, 2015

davidchambers commented May 7, 2015

CrossEye commented May 8, 2015

megawac commented May 8, 2015

buzzdecafe commented May 8, 2015

buzzdecafe commented May 8, 2015

davidchambers commented May 8, 2015

megawac May 9, 2015

Choose a reason for hiding this comment

davidchambers May 9, 2015

Choose a reason for hiding this comment