Add eslint semicolon rule #1948

Merged
merged 2 commits into from Oct 20, 2016

Projects

None yet

4 participants

@davidgtonge
Contributor

I'm not sure why this isn't in the eslint config already. It is the standard for this project - so it makes sense to enforce it with the linter.

After adding the rule - I found 4 examples of missing semicolons which are also fixed in this PR.

davidgtonge added some commits Oct 19, 2016
@davidgtonge davidgtonge Add eslint rule to enforce semicolons
This is the coding standard for this project so it should
be enforced by eslint. This will be particular useful for
new contributors and will save time for reviewers.
270c518
@davidgtonge davidgtonge Add missing semicolons 8fd5c99
@buzzdecafe
Member

LGTM 🐄

@davidchambers
Member

:cow2: has returned! :)

@buzzdecafe
Member
buzzdecafe commented Oct 20, 2016 edited

haha yeah, i liked the camel when i was learning ocaml. and i can't use elm...

@davidchambers
Member

☕️ 📄

@CrossEye
Member

@buzzdecafe: 🌳 ?

🌿 from me, in any case.

@buzzdecafe
Member

clearly, 🌳 is spoken for

@buzzdecafe buzzdecafe merged commit 718952e into ramda:master Oct 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment