chore: rename xf to transducerCreator #3088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrossEye
requested changes
Sep 22, 2020
source/internal/_dispatchable.js
Outdated
| * Otherwise, it will default to executing [fn]. | ||
| * | ||
| * @private | ||
| * @param {Array} methodNames properties to check for a custom implementation | ||
| * @param {Function} xf transducer to initialize if object is transformer | ||
| * @param {Function} transducerCreator transducer constructor if object is transformer |
There was a problem hiding this comment.
Very minor nit. I would use factory here instead of constructor. This is not a constructor function (called with new), so I would avoid the word to avoid confusion.
There was a problem hiding this comment.
Ok, I have changed transducer constructor to transducer factory
CrossEye
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I looked into some source code of ramda related to transducer, and some other articles about transducer, I found out that
xfin_dispatchableis not a transducer, but a transducer constructor.So in order to make the description more clear, I rename
xftotransducerCreator.