Permalink
Commits on Sep 25, 2011
  1. Fix 293, 601: STI subclassing overwrites options

    ramn committed Sep 25, 2011
    Problem: When using STI, and when 'config.cache_classes = true', then
    the STI subclass that gets loaded last will overwrite the options for
    the others. This is due to using Rails class_attribute with a mutable
    hash.
    
    Solution: dup the hash.
Commits on Sep 23, 2011
  1. Bump to 2.4.2

    sikachu committed Sep 23, 2011
  2. Return a URI.escape'd URL from attachment

    sikachu committed Sep 23, 2011
    It's Paperclip's responsibility to escape special characters from the URL to make sure that it's comply with standard.
    
    Closes #577, Closes #563, and reverse my judgement on #482.
  3. Let's try putting a condition up at the top of the file

    sikachu committed Sep 23, 2011
    It was working fine for me locally
  4. Update require in test files

    sikachu committed Sep 23, 2011
  5. fixes #588 . Attempt to log warning message when 2 models use same a…

    Aditya Sanghi authored and sikachu committed Sep 7, 2011
    …ttachment name with default url interpolation
  6. Remove whitespaces

    sikachu committed Sep 23, 2011
  7. Added support for specifying an HTTP Proxy

    ruckus authored and sikachu committed Sep 14, 2011
  8. Ensure that we cache attachment's file name before we perform assignment

    sikachu committed Sep 23, 2011
    There was an issue on assignment another S3 attachment object to another object whereas calling #to_file on S3 attachment will create a Tempfile, which would then having a different file name than original version.
    
    By caching the filename first before calling #to_file, we're ensuring that filename is the original one.
    
    Fixes #9
  9. Remove whitespaces

    sikachu committed Sep 23, 2011
  10. Do not add current model to the class_with_attachment list if it's al…

    sikachu committed Sep 23, 2011
    …ready there
    
    Thank you @Bonias for reporting in
    
    Closes #590
  11. Remove debug puts statement

    sikachu committed Sep 23, 2011
  12. Cleaning up the downloaded original file if it is a tempfile, such as…

    danielevans authored and sikachu committed Sep 15, 2011
    … it is with s3 storage.
  13. Fix the method signature of Interpolations.hash to accept no argument

    sikachu committed Sep 23, 2011
    This will make sure Interpolations is comply with Ruby's Object#hash
    
    Closes #569, Closes #603
Commits on Sep 15, 2011
  1. Whitespace and typos.

    Gabe Berke-Williams
    Gabe Berke-Williams committed Sep 15, 2011
Commits on Sep 11, 2011
Commits on Sep 7, 2011
  1. Bump to 2.4.1

    sikachu committed Sep 7, 2011
  2. Add basic integration test using Cucumber

    sikachu committed Aug 5, 2011
    This test will generate a basic Rails application, include Paperclip
    into Gemfile, and call basic `has_attached_file` in the model. This will
    make sure that we're not messing up any of the configuration and
    integration for our gem and the Rails framework.
  3. Typo, as per usual.

    Gabe Berke-Williams
    Gabe Berke-Williams committed Sep 7, 2011
Commits on Sep 4, 2011
Commits on Sep 3, 2011
  1. Use --mime instead of --mime-type for `file` command

    Chris Oliver and Prem Sichanugrist authored and sikachu committed Sep 3, 2011
    Thank you @excid3 for suggestion.
    
    Closes #582
  2. Remove duplicate test case

    sikachu committed Sep 3, 2011
  3. Remove the Gemfile.lock from git cache

    sikachu committed Sep 3, 2011
    We've ignored the lock file at 3f56e70, so we should remove it as well.
  4. Set the logger to be `AR::Base.logger` or `Rails.logger` when the gem…

    sikachu committed Sep 3, 2011
    … is included to Rails
    
    However, this will make sure that you can always change it to something else afterward.
    
    There's currently no test for this, but after I've tried this with the `integration_test` branch, I can confirm that logs are written to `log/test.log` as it should.
    
    Closes #581
  5. Default the style to default style in #s3_protocol method of S3 storage

    sikachu committed Sep 3, 2011
    Thank you @eric-hu for reporting this regression.
    
    Closes #583
  6. Fix whitespacing issue

    sikachu committed Sep 3, 2011