Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try evaluating code with parentheses before without parentheses #357

Merged
merged 1 commit into from
Nov 8, 2019

Commits on Nov 7, 2019

  1. Try evaluating code with parentheses before without parentheses, closes

    ramnathv#356.
    
    The problem with evaluating without parentheses first is that named function declarations are valid expressions that return undefined (whereas evaluating with parentheses returns the function, as expected).
    
    It's true there may be weird corner-cases where switching this order leads to something else that's undesirable, but we've been operating with the 'with parentheses' model for so long that switching the ordering now will minimize backward-compatibility issues
    cpsievert committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    93c00b8 View commit details
    Browse the repository at this point in the history