toJSON digits parameterization. See danielkrizian/rChartsDygraphs#14 #449

Merged
merged 1 commit into from Aug 4, 2014

Conversation

Projects
None yet
3 participants
Contributor

danielkrizian commented Jun 20, 2014

Adding ability for the user to pass digits parameter to toJSON

This should fix the issues with losing the decimal point precision, as documented here:
danielkrizian/rChartsDygraphs#14 (comment)

danielkrizian referenced this pull request in danielkrizian/rChartsDygraphs Jun 20, 2014

Open

Decimal Point Precision #14

Owner

ramnathv commented Jun 22, 2014

This looks like a straightforward fix. Let me test it at my end before merging.

Contributor

danielkrizian commented Jul 11, 2014

Hi Ramnath, hope you are not too busy these days :)
Did you have a chance to look at this minor change?
Many thanks!

Owner

ramnathv commented Jul 14, 2014

I will add this tonight.

Hi Ramnath,

Sorry to bother you, I was wondering if you had an opportunity to review this change?

Cheers

Owner

ramnathv commented Jul 31, 2014

@TonyDIRL, @danielkrizian My apologies for being behind on this. I will certainly review and merge this over the weekend. Thanks for your patience.

TonyDIRL commented Aug 1, 2014

Very much appreciated, your packages have been a huge help

@ramnathv ramnathv added a commit that referenced this pull request Aug 4, 2014

@ramnathv ramnathv Merge pull request #449 from danielkrizian/master
toJSON digits parameterization. See danielkrizian/rChartsDygraphs#14
f6eb944

@ramnathv ramnathv merged commit f6eb944 into ramnathv:master Aug 4, 2014

TonyDIRL commented Aug 5, 2014

thanks

Contributor

danielkrizian commented Aug 5, 2014

hope we didn't break anything :P

@bfoat bfoat pushed a commit to bfoat/rCharts that referenced this pull request Sep 20, 2014

@ramnathv ramnathv Merge pull request #449 from danielkrizian/master
toJSON digits parameterization. See danielkrizian/rChartsDygraphs#14
a05cfdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment