Skip to content

Conversation

@stephane-monnot
Copy link
Contributor

@stephane-monnot stephane-monnot commented Mar 7, 2018

Tested with :

@alena1108
Copy link
Contributor

@stephane-monnot looks like only vendor.conf got changes, but there are no vendor dependencies updates for ovh. You should run trash (https://github.com/rancher/trash) to pull them in. And on our side, the Drone build should be fixed to catch this type of thing in CI

@stephane-monnot
Copy link
Contributor Author

stephane-monnot commented Mar 13, 2018

Done. I am used to ignore vendor folder in my projects.

@alena1108
Copy link
Contributor

alena1108 commented Mar 13, 2018

@stephane-monnot could you exclude trash.lock from the commit? Otherwise LGTM

@stephane-monnot
Copy link
Contributor Author

stephane-monnot commented Mar 13, 2018

Done. I tried to rebase with master, but I got some errors with the package dnssimple. It seems to be missing.
In vendor.conf, I can see github.com/weppos/go-dnsimple/dnsimple but in the dnssimple provider, the use of github.com/dnsimple/dnsimple-go/dnsimple

@alena1108
Copy link
Contributor

alena1108 commented Mar 13, 2018

@stephane-monnot thanks! I've reverted dns-simple changes, and asked the person to resubmit the PR

@alena1108 alena1108 merged commit 26e8aed into rancher:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants