Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OVH provider #105

Merged
merged 2 commits into from Mar 13, 2018

Conversation

Projects
None yet
2 participants
@stephane-monnot
Copy link
Contributor

stephane-monnot commented Mar 7, 2018

Tested with :

@alena1108

This comment has been minimized.

Copy link
Member

alena1108 commented Mar 13, 2018

@stephane-monnot looks like only vendor.conf got changes, but there are no vendor dependencies updates for ovh. You should run trash (https://github.com/rancher/trash) to pull them in. And on our side, the Drone build should be fixed to catch this type of thing in CI

@stephane-monnot stephane-monnot force-pushed the stephane-monnot:master branch from e34cd9a to 6d1b5f8 Mar 13, 2018

@stephane-monnot

This comment has been minimized.

Copy link
Contributor Author

stephane-monnot commented Mar 13, 2018

Done. I am used to ignore vendor folder in my projects.

@alena1108

This comment has been minimized.

Copy link
Member

alena1108 commented Mar 13, 2018

@stephane-monnot could you exclude trash.lock from the commit? Otherwise LGTM

@stephane-monnot stephane-monnot force-pushed the stephane-monnot:master branch from 6d1b5f8 to 869fd2f Mar 13, 2018

@stephane-monnot stephane-monnot force-pushed the stephane-monnot:master branch from 869fd2f to abc8c46 Mar 13, 2018

@stephane-monnot stephane-monnot force-pushed the stephane-monnot:master branch from abc8c46 to 2bc23f4 Mar 13, 2018

@stephane-monnot

This comment has been minimized.

Copy link
Contributor Author

stephane-monnot commented Mar 13, 2018

Done. I tried to rebase with master, but I got some errors with the package dnssimple. It seems to be missing.
In vendor.conf, I can see github.com/weppos/go-dnsimple/dnsimple but in the dnssimple provider, the use of github.com/dnsimple/dnsimple-go/dnsimple

@alena1108

This comment has been minimized.

Copy link
Member

alena1108 commented Mar 13, 2018

@stephane-monnot thanks! I've reverted dns-simple changes, and asked the person to resubmit the PR

@alena1108 alena1108 merged commit 26e8aed into rancher:master Mar 13, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.