Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make compontentstatus usable #126

Closed
curx opened this Issue Mar 3, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@curx
Copy link
Contributor

curx commented Mar 3, 2019

Is your feature request related to a problem? Please describe.
No, make more act like the k8s ;)

A clear and concise description of what the problem is.
a kubectl get componentstatus give not the expected results

# k3s kubectl get componentstatus
NAME                 STATUS      MESSAGE                                                                                     ERROR
controller-manager   Unhealthy   Get http://127.0.0.1:10252/healthz: dial tcp 127.0.0.1:10252: connect: connection refused   
scheduler            Unhealthy   Get http://127.0.0.1:10251/healthz: dial tcp 127.0.0.1:10251: connect: connection refused  

Describe the solution you'd like
see a clean status

Additional context
Make the controller-manager on 10252 and scheduler listen on the port 10251 and don't disable it or
make it configurable ?

See:
for control-manager:

"--secure-port", "0",

and scheduler:

"--secure-port", "0",

curx added a commit to b1-systems/k3s that referenced this issue Mar 3, 2019

make the controller-manager and scheduler usable for the
componentstatus.
Fixes rancher#126

Signed-off-by: Thorsten Schifferdecker <schifferdecker@b1-systems.de>
@ibuildthecloud

This comment has been minimized.

Copy link
Member

ibuildthecloud commented Mar 3, 2019

The ports are currently disabled because we didn't want any public ports ports exposed. If there is a simple way to make them bind to 127.0.0.1 we can do that. Either which way we will fix it such that component status doesn't return unhealthy.

@ibuildthecloud

This comment has been minimized.

Copy link
Member

ibuildthecloud commented Mar 3, 2019

Oh hey, I didn't see you already put in a PR. Cool, thanks!

@cjellick cjellick added this to the v0.2.0 milestone Mar 8, 2019

@cjellick cjellick added the kind/bug label Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.