Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to provisioned path to include PVC Namespace and Claim name #78

Merged
merged 1 commit into from Mar 6, 2020

Conversation

@REBELinBLUE
Copy link
Contributor

REBELinBLUE commented Mar 3, 2020

As discussed in #77

This seems deceptively simple, am I missing something? I can't seem to find any existing tests?

@REBELinBLUE REBELinBLUE force-pushed the REBELinBLUE:change-pv-path branch from 4db384a to 1dff20c Mar 3, 2020
provisioner.go Outdated Show resolved Hide resolved
@yasker

This comment has been minimized.

Copy link
Member

yasker commented Mar 6, 2020

Can you fold/squash the two commits into one commit? Otherwise LGTM.

@REBELinBLUE REBELinBLUE force-pushed the REBELinBLUE:change-pv-path branch from 22e9148 to b1647bd Mar 6, 2020
@REBELinBLUE

This comment has been minimized.

Copy link
Contributor Author

REBELinBLUE commented Mar 6, 2020

Done

@yasker yasker merged commit 655eac7 into rancher:master Mar 6, 2020
1 check passed
1 check passed
continuous-integration/drone/pr Build is passing
Details
@yasker

This comment has been minimized.

Copy link
Member

yasker commented Mar 6, 2020

Merged, thanks @REBELinBLUE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.