Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster name should be required and unique #13075

Closed
superseb opened this issue Apr 25, 2018 · 4 comments
Closed

Cluster name should be required and unique #13075

superseb opened this issue Apr 25, 2018 · 4 comments
Assignees
Labels
area/api kind/enhancement Issues that improve or augment existing functionality
Milestone

Comments

@superseb
Copy link
Contributor

Version: master 4/25

Although technically not required, we should make Cluster Name required and unique. It's a better user experience for:

  • Users to be warned when accidentally creating a cluster with the same name (this can also happen with multiple users/admins)
  • Users to not be confused when multiple clusters with the same name exists (2 Users creating cluster named A and unknown which is which, apart from specific settings maybe)
  • Users to find their cluster by name instead of the ID (which they may forget/close browser/end of day)
  • Using automation, you get an error when creating the "same" cluster again (same being the same name, with the drawbacks mentioned above)
@superseb superseb added kind/enhancement Issues that improve or augment existing functionality area/ui area/api labels Apr 25, 2018
@loganhz loganhz self-assigned this Apr 27, 2018
@loganhz loganhz mentioned this issue Apr 27, 2018
@vincent99 vincent99 assigned tfiduccia and unassigned loganhz Apr 28, 2018
@vincent99
Copy link
Contributor

vincent99 commented Apr 28, 2018

This really should be enforced in the API if we're going to do it. The UI isn't going to be involved in "automation". @tfiduccia you can look at the UI change in the interim but then kick back to the API.

@tfiduccia
Copy link

API needs to take care of this. We have put in a fix in UI in meantime.

@tfiduccia tfiduccia added this to the v2.0.1 milestone Apr 30, 2018
@loganhz loganhz removed the area/ui label May 3, 2018
@loganhz
Copy link

loganhz commented May 3, 2018

Reverted the UI change. Please add the validation in backend.

@sangeethah
Copy link
Contributor

Tested with latest build from master.
When trying to create cluster with a cluster name that is already associated with another cluster, API fails with error message - "Validation failed in API: Cluster name is not unique"

{"actionLinks":{},"baseType":"error","code":"NotUnique","fieldName":"Cluster name","links":{},"message":"","status":422,"type":"error"}

When trying to create cluster with no name, API fails with error message - "Validation failed in API: Cluster name is required"

{"actionLinks":{},"baseType":"error","code":"MissingRequired","fieldName":"Cluster name","links":{},"message":"","status":422,"type":"error"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api kind/enhancement Issues that improve or augment existing functionality
Projects
None yet
Development

No branches or pull requests

8 participants