Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5] cosmetic: template dropdown full width consistent across all breakpoints #4166

Merged
merged 1 commit into from Sep 29, 2020

Conversation

onpaws
Copy link

@onpaws onpaws commented Sep 14, 2020

Proposed changes

Cosmetic request

There is a feature in Rancher UI, not sure what the correct name is -- I'm calling it the 'chart preview' feature. It can be found by navigating from the main menu Apps->Launch->Chart->PREVIEW and looks like this:
image

This feature can be a convenient way to quickly evaluate new charts. 馃憤

With that said, I'm seeing some cosmetic behavior that could be better - a "quality of life" opportunity having to do with the its responsiveness currently works.

I'm seeing that at smaller browser window widths (breakpoints) this dropdown presents at full width, but at higher widths (e.g. MBP16" maximized browser window for one example) the current classes constrain the dropdown to 33% of the width of the parent div.

Example

breakpoint

With certain larger charts it can become an annoying default, most obviously when the chart in question has a lot going on (e.g. sentry).

This is my first contribution to Rancher, I read through the wiki and I think I'm on track, but but apologies if I missed something. At least in my anecdotal testing on Chrome Canary/macOS, it seems removing these classes restores things back to what I'd consider a 'normal' situation.

With the rise of Helm into a CNCF graduated status, it seems likely Helm charts will only grow in adoption and size. I hope you consider including this PR so future Rancher users benefit from a more convenient UX as they evaluate larger Helm charts. Thanks for your consideration.

Types of changes

  • Cosmetic tweak

Linked Issues

Further comments

Before

before

After

after

@onpaws
Copy link
Author

onpaws commented Sep 29, 2020

@westlywright @vincent99 I'm a first time Rancher UI contributor & hoping to submit a one-liner for consideration. Is there a recommended path I should follow so this gets in front of the right person? Been trying to follow these steps so far. Cheers :)

@westlywright
Copy link
Contributor

westlywright commented Sep 29, 2020

@onpaws thanks for the PR! There is nothing special you need to do. We are currently coming up on our 2.5 release and resources are very much tied up in that effort which can slow down merging as our focus shifts. I got approval and pushed this into the 2.5 release, thanks for the work and well thought out PR.

@westlywright westlywright merged commit 8ab688e into rancher:master Sep 29, 2020
1 check passed
@onpaws
Copy link
Author

onpaws commented Sep 29, 2020

Sounds good and thanks for the merge! Good luck with 2.5, looking forward and rooting for ya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants