Skip to content

feat(rancher-vsphere-cpi): add labels option to vCenter #23

Merged
phillipsj merged 3 commits into
rancher:mainfrom
secustor:cpi_add_labels
May 9, 2022
Merged

feat(rancher-vsphere-cpi): add labels option to vCenter #23
phillipsj merged 3 commits into
rancher:mainfrom
secustor:cpi_add_labels

Conversation

@secustor

@secustor secustor commented Apr 20, 2022

Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • Any new images or tags consumed by charts has been added here
  • That helm lint and pack run successfully on the chart.
  • Deployment of the chart has been tested and verified that it functions as expected.
  • Changes to scripting or CI config have been tested to the best of your ability

Types of Change

  • added the labels configuration to vsphere.conf. This allows to propagate regions and availability zones to nodes and the vSphere CSI
  • use YAML instead of INI as this is recommended as of v1.2.0

Linked Issues

Additional Notes

https://cloud-provider-vsphere.sigs.k8s.io/tutorials/kubernetes-on-vsphere-with-kubeadm.html

NOTE: As of CPI version 1.2.0 or higher, the preferred cloud-config format will be YAML based. The INI based format will be deprecated but supported until the transition to the preferred YAML based configuration has been completed. This deprecation notice will be placed in the CPI logs when using the INI based configuration format.

After the PR is merged

Once the PR is merged, typically upon a new release, please post an announcement in the following channels:

  • #discuss-rancher-feature-charts
  • #discuss-rancher-feature-vsphere
  • #discuss-rancher-k3s-rke2

@secustor secustor marked this pull request as ready for review April 22, 2022 09:33
@secustor secustor requested a review from aiyengar2 as a code owner April 22, 2022 09:33
@phillipsj phillipsj self-requested a review April 22, 2022 13:34
@phillipsj phillipsj self-assigned this Apr 22, 2022
@phillipsj

Copy link
Copy Markdown
Contributor

@secustor thanks for the PR. We will review it next week.

@phillipsj phillipsj added the enhancement New feature or request label Apr 22, 2022
@phillipsj

Copy link
Copy Markdown
Contributor

@secustor can you rebase on the latest main branch? I will merge after that.

@phillipsj phillipsj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rosskirkpat rosskirkpat left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillipsj phillipsj merged commit 3cea7fc into rancher:main May 9, 2022
@phillipsj

Copy link
Copy Markdown
Contributor

@secustor thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants