feat(rancher-vsphere-cpi): add labels option to vCenter #23
Merged
Conversation
…onf to yaml style
…place conf to yaml style
Contributor
|
@secustor thanks for the PR. We will review it next week. |
Contributor
|
@secustor can you rebase on the latest main branch? I will merge after that. |
Contributor
|
@secustor thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Types of Change
vsphere.conf. This allows to propagate regions and availability zones to nodes and the vSphere CSIv1.2.0Linked Issues
Additional Notes
https://cloud-provider-vsphere.sigs.k8s.io/tutorials/kubernetes-on-vsphere-with-kubeadm.html
After the PR is merged
Once the PR is merged, typically upon a new release, please post an announcement in the following channels: