feat: refactored coroutine pipeline so nothing can get stuck#166
Merged
Conversation
Contributor
CluEleSsUK
commented
Oct 13, 2025
CluEleSsUK
commented
- added lots of gucci comments
- nearly lost my mind understanding async rust
- added lots of gucci comments - nearly lost my mind understanding async rust
najienka
reviewed
Oct 13, 2025
| .signer | ||
| .sign(&solver, &s.chain_state.swap_params) | ||
| .await | ||
| .context("signing failed somehow")?; |
Contributor
There was a problem hiding this comment.
Do we get any meaningful error messages that we can log here to help with debugging? @CluEleSsUK
Contributor
Author
There was a problem hiding this comment.
yes, this .context() call actually wraps the original error, so you get all the original messages too, e.g. https://docs.rs/anyhow/latest/anyhow/trait.Context.html
najienka
approved these changes
Oct 13, 2025
AnomalRoil
reviewed
Oct 13, 2025
| use crate::chain_state::NetworkBus; | ||
| use crate::chain_state_pending::{RequestId, Verification}; | ||
| use crate::chain_state_resolver::ChainStateResolver; | ||
| use crate::app::App; |
Member
There was a problem hiding this comment.
This is a terrible name for a crate in a repo with multiple binaries.
Contributor
Author
There was a problem hiding this comment.
it’s a module name within a crate, not a crate name.
Have used it as a naming convention for some other bins, but open to other suggestions
Member
There was a problem hiding this comment.
use crate::app::Verifier would probably be clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.