feat(randomness): add BLS2 support#59
Merged
Merged
Conversation
bbjubjub2494
force-pushed
the
feat/randomness-bls12_381
branch
2 times, most recently
from
4b62cca to
eebec5a
Compare
bbjubjub2494
force-pushed
the
feat/randomness-bls12_381
branch
from
eebec5a to
49af9d2
Compare
bbjubjub2494
force-pushed
the
feat/randomness-bls12_381
branch
2 times, most recently
from
6084bb2 to
9492e68
Compare
bbjubjub2494
force-pushed
the
feat/randomness-bls12_381
branch
from
9492e68 to
5084aee
Compare
bbjubjub2494
force-pushed
the
feat/randomness-bls12_381
branch
from
c132f22 to
b03e4df
Compare
AnomalRoil
requested changes
Sep 3, 2025
Member
AnomalRoil
left a comment
AnomalRoil
left a comment
There was a problem hiding this comment.
Last batch of comments, LGTM after these
Comment on lines
+348
to
+351
| G1Affine<BLS>: | ||
| PointSerializeCompressed + PointDeserializeCompressed + PointSerializeUncompressed, | ||
| G2Affine<BLS>: | ||
| PointSerializeCompressed + PointDeserializeCompressed + PointSerializeUncompressed, |
Member
There was a problem hiding this comment.
Why PointDeserializeCompressed but not PointDeserializeUncompressed?
Member
Author
There was a problem hiding this comment.
There's no scenario in which it is actually needed: internally, we serialize and deserialize using the compressed format. If the signature scheme requires it, we can serialize in uncompressed format at the end, but we never deserialize. That said, we could also consider this an implementation detail and hide it. (Or merge the traits tbh)
bbjubjub2494
force-pushed
the
feat/randomness-bls12_381
branch
3 times, most recently
from
a1914a5 to
4ab614e
Compare
bbjubjub2494
commented
Sep 4, 2025
bbjubjub2494
force-pushed
the
feat/randomness-bls12_381
branch
from
4ab614e to
7b09b56
Compare
bbjubjub2494
force-pushed
the
feat/randomness-bls12_381
branch
from
0ee3436 to
79b3a66
Compare
azixus
approved these changes
Sep 5, 2025
AnomalRoil
approved these changes
Sep 8, 2025
AnomalRoil
approved these changes
Sep 8, 2025
bbjubjub2494
force-pushed
the
feat/randomness-bls12_381
branch
from
e362387 to
2134fd3
Compare
…randomness-bls12_381
bbjubjub2494
force-pushed
the
feat/randomness-bls12_381
branch
from
2134fd3 to
b59b892
Compare
AnomalRoil
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #60, randa-mu/randomness-solidity#27 and randa-mu/dcipher-proto#2