/random-access-file

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use asbtract-random-access #7

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@juliangruber @feross @jwerle
@juliangruber
Collaborator

juliangruber commented Jul 27, 2016

Not a single test failed after I integrated the base class, so there might be some details that I've missed.

Also, I didn't change the thunky(open) behavior, should this rather live inside abstract-random-access?
@juliangruber
use asbtract-random-access
Loading status checks…
9404982
@feross

This comment has been minimized.

Show comment
Hide comment
@feross

feross Aug 8, 2016

Collaborator

I'll defer to @mafintosh on this.
Collaborator

feross commented Aug 8, 2016

I'll defer to @mafintosh on this.
@jwerle

This comment has been minimized.

Show comment
Hide comment
@jwerle

jwerle Mar 9, 2018

should we close since this is using random-access-storage now? :]

jwerle commented Mar 9, 2018

should we close since this is using random-access-storage now? :]
@feross

This comment has been minimized.

Show comment
Hide comment
@feross

feross Apr 15, 2018

Collaborator

Sure, closed!
Collaborator

feross commented Apr 15, 2018

Sure, closed!

@feross feross closed this Apr 15, 2018

@feross feross deleted the use/abstract-random-access branch Apr 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment