Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to install radian from conda-forge #244

Closed
gvelasq opened this issue Jan 15, 2021 · 9 comments
Closed

Add option to install radian from conda-forge #244

gvelasq opened this issue Jan 15, 2021 · 9 comments

Comments

@gvelasq
Copy link
Contributor

gvelasq commented Jan 15, 2021

Thank you for this great R console. Would you consider adding radian as a recipe to conda-forge?

@randy3k
Copy link
Owner

randy3k commented Jan 15, 2021

I am not familiar with the procedure. I am happy if someone could initiate this.

@jdblischak
Copy link

I can work on this. In addition to radian, we'll also need to add rchitect.

@jdblischak
Copy link

@gvelasq Thanks for getting the discussion started and providing a central location to track progress. Please give it a try:

conda install -c conda-forge radian

@randy3k Thanks for all your help getting your packages on conda-forge (and of course for creating and maintaining this awesome R console).

@gvelasq
Copy link
Contributor Author

gvelasq commented Feb 10, 2021

@jdblischak and @randy3k, thank you very much for setting this up. I can confirm that installing radian works perfectly when installing from conda-forge. I also used conda-forge to install jedi after installing radian and it was very convenient that the correct correct version of jedi was installed automatically.

On our end, @ivelasq and I will edit our recent blog post to show the simplified installation instructions from conda-forge and we'll thank you for your efforts there.

@jdblischak
Copy link

On our end, @ivelasq and I will edit our recent blog post to show the simplified installation instructions from conda-forge and we'll thank you for your efforts there.

Great blog post. I really enjoyed it, and I hope to try out live sharing in the future. And since you're clearly fans of conda-forge, I have to point out that you can also install R and R packages from conda-forge. Then both your Python and R setup can be isolated per environment/project.

@gvelasq
Copy link
Contributor Author

gvelasq commented Feb 12, 2021

Closed in 8448e03. Many thanks!

@gvelasq gvelasq closed this as completed Feb 12, 2021
@randy3k
Copy link
Owner

randy3k commented Mar 29, 2021

@jdblischak
just want to let you know that the next version of radian 0.5.11 will support jedi 0.18.

@jdblischak
Copy link

just want to let you know that the next version of radian 0.5.11 will support jedi 0.18.

Great! How do you want to proceed with updating the conda recipe? I see multiple options:

  1. Update run_constrains to jedi <= 0.18. I think this is the most conservative approach. It'll allow radian to be used with jedi 0.18 or earlier, but make no guarantees about future versions of jedi (and actively prevent this situation).
  2. Move jedi to a strict dependency. This is the most aggressive option. But if most users will want the features that jedi provides, it would make sense.
  3. Remove jedi from the recipe all together. This would allow it to be handled similarly to R. Users are free to install it however they like.

@randy3k
Copy link
Owner

randy3k commented Mar 30, 2021

I guess we could remove the requirement as a whole. I don't expect the code to break any time soon.

edit: by the requirement, I meant "version requirement". I vote for #2 to avoid version collisions with ipython or python-language-server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants