New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for enabling or disabling smoothed lines in a scatter series #347

Merged
merged 2 commits into from Mar 14, 2015

Conversation

Projects
None yet
2 participants
@ionthegeek

ionthegeek commented Aug 19, 2014

I noticed I was getting line smoothing even when a scatter chart's scatter style was set to a non-smoothed one. This change should set the series smoothing defaults based on scatter style of the chart but also allows smoothing to be enabled or disabled on a per-series basis.

Unfortunately this seems to be Excel-specific behaviour and is technically in violation of the Office Open XML standard (see http://msdn.microsoft.com/en-us/library/ff535259(v=office.12).aspx) but since Excel isn't compliant with the standard, I don't see another way to do this and have it work in Excel.

I added tests for default smooth settings and overriding smooth settings.

jurriaan added a commit that referenced this pull request Mar 14, 2015

Merge pull request #347 from ionthegeek/smoothing
Add support for enabling or disabling smoothed lines in a scatter series

@jurriaan jurriaan merged commit 05c9faa into randym:master Mar 14, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment