New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding #151

Closed
ranelytics opened this Issue Jan 24, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@ranelytics

Hey Randy,

first of all thanks for this great package - It is very helpful for my day-to-day work!

After reading the package documentation thoroughly i encountered some kind of problem concerning german letters (mutated vowels like `Ä, Ö, Ü') in page names, search keywords e.g. if i try to fetch search keywords as described in one of your blog posts some of the words are just hard to read. I want to emphasie that the query results are reasonable per se, they just dont seem to be formatted/encoded in the right way.

Example:
Instead of Öffnungszeit, which would be the correct term, the result of a ranked query is ãffnungszeit.

umlaute_rsitecatalyst

Maybe i am just not aware of some kind of language/encoding option in your package? Do you consider this a bug?

Thanks,
Lukas

@randyzwitch

This comment has been minimized.

Show comment
Hide comment
@randyzwitch

randyzwitch Jan 24, 2016

Owner

Hi Lukas, glad you are finding the package useful!

This is really just an oversight on my part, given my American-ness. This has never come up before, so I never implemented the encoding part of the API. :)

It shouldn't be too difficult to implement, it's just a lot of methods, so hopefully I can work on this in the upcoming week,

Owner

randyzwitch commented Jan 24, 2016

Hi Lukas, glad you are finding the package useful!

This is really just an oversight on my part, given my American-ness. This has never come up before, so I never implemented the encoding part of the API. :)

It shouldn't be too difficult to implement, it's just a lot of methods, so hopefully I can work on this in the upcoming week,

randyzwitch added a commit that referenced this issue Jan 25, 2016

@randyzwitch

This comment has been minimized.

Show comment
Hide comment
@randyzwitch

randyzwitch Jan 25, 2016

Owner

@ranelytics, could you test this out for me? You can install the patched version using:

install.packages("devtools")
library(devtools)
install_github("randyzwitch/RSiteCatalyst", ref="master")

There are two changes. First, just try to run your same code as you did before and see if your issues are fixed. There was an option for UTF-8 encoding, so I turned that on. If that doesn't work, SCAuth now has a keyword option for locale, and you can set Germany as your locale de_DE.

Thanks.

Owner

randyzwitch commented Jan 25, 2016

@ranelytics, could you test this out for me? You can install the patched version using:

install.packages("devtools")
library(devtools)
install_github("randyzwitch/RSiteCatalyst", ref="master")

There are two changes. First, just try to run your same code as you did before and see if your issues are fixed. There was an option for UTF-8 encoding, so I turned that on. If that doesn't work, SCAuth now has a keyword option for locale, and you can set Germany as your locale de_DE.

Thanks.

@ranelytics

This comment has been minimized.

Show comment
Hide comment
@ranelytics

ranelytics Jan 26, 2016

@randyzwitch, its working even without specifiying the new locale option but i added it nevertheless. you never know :)

again, thanks for this great package!

@randyzwitch, its working even without specifiying the new locale option but i added it nevertheless. you never know :)

again, thanks for this great package!

@randyzwitch

This comment has been minimized.

Show comment
Hide comment
@randyzwitch

randyzwitch Jan 27, 2016

Owner

Great, thanks for confirming! I'll send a new version to CRAN in the coming days.

You're quite welcome for the package, I hope you continue to find it useful.

Owner

randyzwitch commented Jan 27, 2016

Great, thanks for confirming! I'll send a new version to CRAN in the coming days.

You're quite welcome for the package, I hope you continue to find it useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment