New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing OAUTH2 authentication #224

Merged
merged 2 commits into from Jul 20, 2017

Conversation

Projects
None yet
2 participants
@leocwlau
Contributor

leocwlau commented Jul 18, 2017

  1. Moved company='' within auth.method='OAUTH2', else company will always be '' when auth.method='OAUTH2'
  2. Updated value extraction from sc.cred with new list 'credentials' for credential information
@randyzwitch

This comment has been minimized.

Show comment
Hide comment
@randyzwitch

randyzwitch Jul 18, 2017

Owner
Owner

randyzwitch commented Jul 18, 2017

@randyzwitch

This comment has been minimized.

Show comment
Hide comment
@randyzwitch

randyzwitch Jul 19, 2017

Owner

Thanks, this worked for me. In #223, you mentioned something about token refreshes and .httr-auth. Is that something you want to tackle as part of this PR or should I just merge this in?

Owner

randyzwitch commented Jul 19, 2017

Thanks, this worked for me. In #223, you mentioned something about token refreshes and .httr-auth. Is that something you want to tackle as part of this PR or should I just merge this in?

@leocwlau

This comment has been minimized.

Show comment
Hide comment
@leocwlau

leocwlau Jul 20, 2017

Contributor

Please just merge this in first. I wish to spend a bit more time on the other two issues to confirm their existence and try to fix in future PR(s)

Contributor

leocwlau commented Jul 20, 2017

Please just merge this in first. I wish to spend a bit more time on the other two issues to confirm their existence and try to fix in future PR(s)

@randyzwitch

This comment has been minimized.

Show comment
Hide comment
@randyzwitch

randyzwitch Jul 20, 2017

Owner

Sounds great. Thanks for this contribution, fixes from the community are always super appreciated!

Owner

randyzwitch commented Jul 20, 2017

Sounds great. Thanks for this contribution, fixes from the community are always super appreciated!

@randyzwitch randyzwitch merged commit 2df0b22 into randyzwitch:master Jul 20, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details

@gilliganondata gilliganondata referenced this pull request Sep 11, 2017

Closed

Curl Error #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment