"--" argument is badly supported #34

Closed
adam8157 opened this Issue Apr 12, 2012 · 10 comments

Comments

Projects
None yet
2 participants

Hi, hut

As $subject, most programs don't support "--" argument.

For example, libreoffice doesn't support, but rifle.conf does.

And I recommend you to remove "--" from open_with, most programs fails, and all my scripts use for args in "$@" fails. Please...

Owner

hut commented Apr 12, 2012

At first, some entries were buggy, but I tested almost all of them and fixed the wrong ones. Maybe you have an early, outdated rifle.conf? I did not test these programs yet: okular, kspread, totem and I don't know how many openoffice variants there are.... but I assumed they support it.

Removing "--" from all programs is a bad idea because it breaks handling of files starting with a "-" for all programs which interpret them as options. And most programs do support the "--" argument, including libreoffice 3.5 on archlinux. If you're absolutely sure that your version of libreoffice doesn't support it, I will remove it from libreoffice/openoffice for compatibility. Please point out any other programs which are affected by this.

And if your scripts don't support it, don't add it to the line in rifle.conf.

Thanks for reply.

Maybe I didn't make myself clear. I mean remove "--" from open_with, we can't assume all programs support it, right?

If there is a file statring with a "-", user can add "--" manually(if they know how to create those files, they know "--"). Or, parse filename first, if starting with a "-", then use "--".

BTW, that libreoffice's version is 3.4, Fedora 16. And the libreoffice in Debian sid seems fine.

Owner

hut commented Apr 18, 2012

Yes, I misunderstood. It's fixed now, thank you

@hut hut closed this Apr 18, 2012

adam8157 commented May 6, 2012

It comes out again, by c908fd3 ?

Owner

hut commented May 6, 2012

Fixed, sorry =)

On Sun, May 06, 2012 at 06:04:19AM -0700, Adam Lee wrote:

It comes out again, by c908fd3 ?


Reply to this email directly or view it on GitHub:
hut#34 (comment)

Owner

hut commented May 6, 2012

Due to my sloppiness, different repositories got out of sync and I had to make a forced update. It should be correct now, but you might experience problems when pulling from this git repo...

adam8157 commented May 6, 2012

It's OK "again", :) Thank you.

BTW, changing a shared repo's history is not a good idea, another commit looks mess, but better for scm

Owner

hut commented May 6, 2012

I know =/ But it was the only solution.
The repo at git://git.savannah.nongnu.org/ranger.git was always in good condition, but at some point I accidently "broke" the github repo. The only solution was to reset the history of the github repo to the same as the savannah repo.

Please remove "--" from libreoffice command line, it don't support "--".

Name : libreoffice
Arch : x86_64
Epoch : 1
Version : 3.5.4.2
Release : 1.fc17

Owner

hut commented Jun 15, 2012

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment