From ee4294919db786afd4e0442fc4221cf54f2bb20d Mon Sep 17 00:00:00 2001 From: Chris Cormack Date: Fri, 20 Sep 2013 09:58:51 +1200 Subject: [PATCH] Tidying up and starting to extend the handler Signed-off-by: Chris Cormack Conflicts: lib/NCIP/Handler/LookupItem.pm --- lib/NCIP.pm | 2 +- lib/NCIP/Handler/LookupItem.pm | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/NCIP.pm b/lib/NCIP.pm index b84dca6..86c7328 100644 --- a/lib/NCIP.pm +++ b/lib/NCIP.pm @@ -106,7 +106,7 @@ sub validate { catch { warn "Bad xml, caught error: $_"; return; - } + }; # we could validate against the dtd here, might be good? # my $dtd = XML::LibXML::Dtd->parse_string($dtd_str); diff --git a/lib/NCIP/Handler/LookupItem.pm b/lib/NCIP/Handler/LookupItem.pm index 77c758f..6629da6 100644 --- a/lib/NCIP/Handler/LookupItem.pm +++ b/lib/NCIP/Handler/LookupItem.pm @@ -28,7 +28,6 @@ sub handle { if ($xmldoc) { # my ($item_id) = $dom->getElementsByTagNameNS( $nsURI, 'ItemId' ); } - des = $dom->getElementsByTagNameNS( $nsURI, 'NCIPMessage' ); return $self->type; }