Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around webpack production autoprefixing bug #137

Closed
SethDavenport opened this issue Jun 27, 2016 · 0 comments
Closed

Work around webpack production autoprefixing bug #137

SethDavenport opened this issue Jun 27, 2016 · 0 comments

Comments

@SethDavenport
Copy link
Contributor

It turns out that webpack.UglifyJSPlugin sets a 'minification' parameter to all loaders, not just the JavaScript one. This in turn causes css-loader to do its own minification, which involves removing 'deprecated' vendor prefixes, including -webkit-flex.

This all happens after our cssnano/autoprefixer stuff so our browserlist file isn't fully respected in the final output.

See PatrickJS/PatrickJS-starter#644 and webpack/webpack#283 for more context on this issue with webpack.UglifyJSPlugin.

The workaround is to explicitly turn off css-loader's built-in minification, since we're handling it in a controlled way with cssnano anyway.

SethDavenport pushed a commit to SethDavenport/angular2-redux-example that referenced this issue Jun 29, 2016
Work around a well known webpack.UglifyJSPlugin behaviour that strips -webpack prefixes regardless of autoprefixer settings.

Separate the browser version specs into a `browserslist` file.

Connected to rangle/rangle-starter#137
@SethDavenport SethDavenport self-assigned this Jun 29, 2016
SethDavenport pushed a commit to SethDavenport/angular2-starter that referenced this issue Jun 29, 2016
Work around a well known webpack.UglifyJSPlugin behaviour that strips -webpack prefixes regardless of autoprefixer settings.

Separate the browser version specs into a browserslist file.

Connected to rangle/rangle-starter#137
SethDavenport pushed a commit to SethDavenport/angular-redux-starter that referenced this issue Jun 29, 2016
Work around a well known webpack.UglifyJSPlugin behaviour that strips -webpack prefixes regardless of autoprefixer settings.

Separate the browser version specs into a browserslist file.

Connected to rangle/rangle-starter#137
SethDavenport pushed a commit to SethDavenport/typescript-react-redux-starter that referenced this issue Jun 29, 2016
Work around a well known webpack.UglifyJSPlugin behaviour that strips -webpack prefixes regardless of autoprefixer settings.

Separate the browser version specs into a browserslist file.

Connected to rangle/rangle-starter#137
SethDavenport pushed a commit to SethDavenport/react-redux-starter that referenced this issue Jun 29, 2016
Work around a well known webpack.UglifyJSPlugin behaviour that strips -webpack prefixes regardless of autoprefixer settings.

Separate the browser version specs into a browserslist file.

Connected to rangle/rangle-starter#137
clbond added a commit to clbond/typescript-react-redux-starter that referenced this issue Jul 4, 2016
Applied recent lessons learned for Autoprefixer (#160)

Work around a well known webpack.UglifyJSPlugin behaviour that strips -webpack prefixes regardless of autoprefixer settings.

Separate the browser version specs into a browserslist file.

Connected to rangle/rangle-starter#137

* Switch repo from mocha to karma (unit test runner)
* Add TypeScript code coverage report generated by Istanbul

Remove patch rejection file, add *.rej and *.orig to gitignore

* Put various React typings into the global list
* Remove another patch rejection file

Incorrect typings.json configuration

Remove corejs dependency and use babel-polyfill

Add code coverage information to $CIRCLE_ARTIFACTS

Disable verbose webpack output

Bump the remap-istanbul timeout because it is too low for CircleCI

Remove call to toString()

Remove unused test entry

Remove unused dependencies (these are provided by babel-polyfill)

Add jasmine typings instead of mocha
wangxpert pushed a commit to wangxpert/angular-redux-starter that referenced this issue Nov 8, 2017
Work around a well known webpack.UglifyJSPlugin behaviour that strips -webpack prefixes regardless of autoprefixer settings.

Separate the browser version specs into a browserslist file.

Connected to rangle/rangle-starter#137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant