Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for custom dimensions #181

Merged
merged 3 commits into from Feb 3, 2018

Conversation

@bzswords
Copy link
Contributor

commented Feb 2, 2018

This just adds documentation on how to take advantage of the new hit types added by @djw27 in their PR.

@ttmarek forked off of @djw27's project. Not sure if this is the what you were expecting. I can change the base of this fork if needed.

Dan and others added some commits Jan 9, 2018

Update docs for react native google analytics target to include event…
…CustomDimensions, pageviewCustomDimensions, user and client

@ttmarek ttmarek merged commit 741e9df into rangle:master Feb 3, 2018

1 check failed

ci/circleci Your tests failed on CircleCI
Details
@ttmarek

This comment has been minimized.

Copy link
Member

commented Feb 3, 2018

@bzswords @djw27 thanks for all your hard work on this guys! 💯
It's much appreciated 🙂.

I'll let you know once these changes are published to npm.

@djw27

This comment has been minimized.

Copy link
Contributor

commented Feb 6, 2018

@bzswords @ttmarek thanks for getting this merged & adding the docs!

@bzswords

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2018

@ttmarek any update on when this will be published?

@ttmarek

This comment has been minimized.

Copy link
Member

commented Feb 22, 2018

Hey @bzswords. Sorry, some clients are in town this week so I haven't had any open evenings to work on the next release. It is so so close though. I wrote a checklist of what's left in this issue here:
#180

In the meantime I would opt for simple copy-pasting the entire react-native-google-analytics target into your repo. In the next release this will be published separately under @redux-beacon/react-native-google-analytics as described here

Any help would be greatly appreciated if you can spare a moment or two. Adding typescript definitions for each event-helper would be fairly straightforward and a huge win.

@bzswords

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2018

@ttmarek thank you for the response, i totally understand. i may actually have time this weekend to contribute. ill comment on that checklist if so.

@OKNoah OKNoah referenced this pull request Oct 31, 2018
3 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.