New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enconde/decode the key value pair to UTF-8 solves #37 #44

Merged
merged 1 commit into from Oct 9, 2016

Conversation

Projects
None yet
3 participants
@jluis
Contributor

jluis commented Oct 4, 2016

When _wrap_utf8 is called $key and $value contain a strean of octets
encoded on UTF-8 but we need the secuence of characters to calculate
the where to wrap (or 'fold') the line

The t/unwrap.vcf is from pull request #38 test for isue #37

Signed-off-by: Jose Luis Perez Diez jluis@escomposlinux.org

Enconde/decode the key value pair to UTF-8 solves #37
When _wrap_utf8 is called $key and $value contain a strean of octets
encoded on UTF-8 but we need the secuence of characters to calculate
the where to wrap (or 'fold') the line

The t/unwrap.vcf is from pull request #38 test for isue #37

Signed-off-by: Jose Luis Perez Diez <jluis@escomposlinux.org>
@ranguard

This comment has been minimized.

Show comment
Hide comment
@ranguard

ranguard Oct 9, 2016

Owner

@kablamo are you happy with this :) ?

Owner

ranguard commented Oct 9, 2016

@kablamo are you happy with this :) ?

@kablamo

This comment has been minimized.

Show comment
Hide comment
@kablamo

kablamo Oct 9, 2016

Collaborator

Gah @ranguard I really have no idea. This unicode stuff is beyond me and trying to figure it out has stopped being fun. I'd say the tests pass and it solves his problem and doesn't break existing tests so I'm all for merging it. Sorry I'm not more useful here!

Collaborator

kablamo commented Oct 9, 2016

Gah @ranguard I really have no idea. This unicode stuff is beyond me and trying to figure it out has stopped being fun. I'd say the tests pass and it solves his problem and doesn't break existing tests so I'm all for merging it. Sorry I'm not more useful here!

@ranguard ranguard merged commit d5d8571 into ranguard:master Oct 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ranguard ranguard referenced this pull request Oct 9, 2016

Closed

Test for issue #37 #38

@ranguard

This comment has been minimized.

Show comment
Hide comment
@ranguard

ranguard Oct 9, 2016

Owner

Thanks @jluis appreciate the work you've done

Owner

ranguard commented Oct 9, 2016

Thanks @jluis appreciate the work you've done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment