Require at least one value

ranguba · Apr 13, 2017 · 17c2231 · 17c2231
1 parent b4f0c75
commit 17c2231
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/lib/groonga/client/request/select.rb b/lib/groonga/client/request/select.rb
@@ -187,17 +187,21 @@ def initialize(request)
           #
           # @param [String, Symbol] column_name The target column name.
           #
-          # @param [Object] values The column values that cover target
+          # @param [Object] value A column value that cover target
           #   column values.
           #
+          # @param [Object] values The rest column values that cover
+          #   target column values.
+          #
           # Adds a `in_values` condition then return a new `select`
           # request object.
           #
           # @return [Groonga::Client::Request::Select]
           #   The new request with the given condition.
-          def in_values(column_name, *values)
-            add_parameter(FilterMerger,
-                          FilterInValuesParameters.new(column_name, *values))
+          def in_values(column_name, value, *values)
+            parameters =
+              FilterInValuesParameters.new(column_name, value, *values)
+            add_parameter(FilterMerger, parameters)
           end
 
           private

diff --git a/test/request/test-select.rb b/test/request/test-select.rb
@@ -112,6 +112,12 @@ def in_values(column_name, *values)
                      },
                      in_values("tags", "groonga", "have \"double\" quote"))
       end
+
+      test("no values") do
+        assert_raise(ArgumentError) do
+          in_values("tags")
+        end
+      end
     end
   end