Navigation Menu

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ranguba/groonga-client
base: 6d1b3a7e4db3
Choose a base ref
...
head repository: ranguba/groonga-client
compare: ab55abb6aae5
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Apr 26, 2017

  1. test: remove needless tests

    For example, the following case focuses Ruby's basic feature (argument
    check feature). It's not a test area of us.
    
        test("no values") do
          assert_raise(ArgumentError){ between("tags") }
        end
    
    For example, the following case doesn't show expected behavior. We
    expect String or Symbol as the first argument. We don't expect number as
    the first argument. It's unexpected behavior (we can validate the first
    argument or we just use the argument value because it's responsive of
    user). We shouldn't add a test for the unexpected behavior. If we
    validate the first argument then it's reasonable that we add a test
    that the method raises for wrong value.
    
        test("number_include") do
          assert_equal({
                         :table => "posts",
                         :filter => "between(10, 2, \"include\", 29, \"include\")",
                       },
                       between(10, 2, "include", 29, "include"))
        end
    kou committed Apr 26, 2017
    Copy the full SHA
    ab55abb View commit details
    Browse the repository at this point in the history