Add Column#weight_vector?

ranguba · Apr 25, 2017 · 2e9786d · 2e9786d
1 parent 75fc614
commit 2e9786d
Show file tree

Hide file tree

Showing 4 changed files with 47 additions and 0 deletions.
diff --git a/ext/groonga/rb-grn-column.c b/ext/groonga/rb-grn-column.c
@@ -654,6 +654,26 @@ rb_grn_column_vector_p (VALUE self)
     return CBOOL2RVAL(grn_obj_is_vector_column(context, column));
 }
 
+/*
+ * @overload weight_vector?
+ *   @return [Bool] `true` if the column is a weight vector column,
+ *   `false` otherwise.
+ *
+ * @since 7.0.2
+ */
+static VALUE
+rb_grn_column_weight_vector_p (VALUE self)
+{
+    grn_ctx *context;
+    grn_obj *column;
+
+    rb_grn_column_deconstruct(SELF(self), &column, &context,
+                             NULL, NULL,
+                             NULL, NULL, NULL);
+
+    return CBOOL2RVAL(grn_obj_is_weight_vector_column(context, column));
+}
+
 /*
  * _column_ がスカラーカラムの場合は +true+ を返し、
  * そうでない場合は +false+ を返す。
@@ -834,6 +854,8 @@ rb_grn_init_column (VALUE mGrn)
     /* deprecated: backward compatibility */
     rb_define_alias(rb_cGrnColumn, "index_column?", "index?");
     rb_define_method(rb_cGrnColumn, "vector?", rb_grn_column_vector_p, 0);
+    rb_define_method(rb_cGrnColumn, "weight_vector?",
+                     rb_grn_column_weight_vector_p, 0);
     rb_define_method(rb_cGrnColumn, "scalar?", rb_grn_column_scalar_p, 0);
 
     rb_define_method(rb_cGrnColumn, "with_weight?",

diff --git a/test/test-fix-size-column.rb b/test/test-fix-size-column.rb
@@ -128,6 +128,12 @@ def test_vector?
       assert_not_predicate(@n_viewed, :vector?)
     end
 
+    def test_weight_vector?
+      assert do
+        not @n_viewed.weight_vector?
+      end
+    end
+
     def test_scalar?
       assert_predicate(@n_viewed, :scalar?)
     end

diff --git a/test/test-index-column.rb b/test/test-index-column.rb
@@ -48,6 +48,12 @@ def test_vector?
       assert_not_predicate(@index, :vector?)
     end
 
+    def test_weight_vector?
+      assert do
+        not @index.weight_vector?
+      end
+    end
+
     def test_scalar?
       assert_not_predicate(@index, :scalar?)
     end

diff --git a/test/test-variable-size-column.rb b/test/test-variable-size-column.rb
@@ -46,6 +46,13 @@ def setup_users_table
       @users.define_column("nick_names", "ShortText",
                            :type => :vector,
                            :path => @users_nick_names_column_path.to_s)
+
+    @users_tags_column_path = @columns_dir + "tags"
+    @tags =
+      @users.define_column("tags", "ShortText",
+                           :type => :vector,
+                           :with_weight => true,
+                           :path => @users_tags_column_path.to_s)
   end
 
   def setup_users
@@ -62,6 +69,12 @@ def test_vector?
     assert_predicate(@nick_names, :vector?)
   end
 
+  def test_weigth_vector?
+    assert do
+      @tags.weight_vector?
+    end
+  end
+
   def test_scalar?
     assert_not_predicate(@nick_names, :scalar?)
   end