Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x_maturity #26

Merged
merged 4 commits into from
Nov 16, 2021
Merged

Add x_maturity #26

merged 4 commits into from
Nov 16, 2021

Conversation

maximusunc
Copy link
Collaborator

  • Adds openapi schema with x_maturity to the kp registry.
  • Adds logic to the kp registry so external services can request KPs of a specific x_maturity.

#25

Copy link
Contributor

@cbizon cbizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In retrieve_kp_endpoints_from_smartapi, we're only looking at the first element in servers. We should probably take this opportunity to handle all the elements in that list. With multiple environments, one option that people may take advantage of is using the same registration, and pointing to both prod and dev as two server entries.

Also, I think we need to go ahead and implement the TODO on line 174/5 of registry.py and assume maturity is a list.

@maximusunc
Copy link
Collaborator Author

In order to pick the better instance, we need to be able to compare similar services. Right now, the only field that would remain constant between service instances is the infores, which is a relatively new required property. I'll need to add infores to the information we store on each service. Until all services add the infores property, we might lose some otherwise valid kps.

@cbizon
Copy link
Contributor

cbizon commented Nov 15, 2021

Yes, that's why infores has been added. I think rather than loosing any, we should create a unique infores for anything that doesn't have one, and then complain to the offending team.

@maximusunc
Copy link
Collaborator Author

maximusunc commented Nov 15, 2021

Just for clarification, if we create unique inforeses for services that don't have them, we'll potentially be hitting both dev and prod of a service since we couldn't compare them correctly.

@maximusunc
Copy link
Collaborator Author

Just for clarification, if we create unique inforeses for services that don't have them, we'll potentially be hitting both dev and prod of a service since we couldn't compare them correctly.

Actually, if services have added x-maturity and multiple instances, then they would have also added infores, so we're probably fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants