{{ message }}

# Circular correlation for uniform marginals#64

Merged
merged 1 commit into from Sep 3, 2019
Merged

# Circular correlation for uniform marginals#64

merged 1 commit into from Sep 3, 2019

## Conversation

This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters

### dominikstrb commented Sep 3, 2019

 According to Jammalamadaka & Sengupta (2001, pg. 177) the circular means are not well defined if the marginal distribution of one of the angles is uniform. This leads to wrong estimates of circular correlations in these cases. There is an alternative formulation of the circular correlation coefficient that deals with this problem (see equation 8.2.4 in Jammalamadaka & Sengupta, 2001). This implementation can also lead to slightly different values for the coefficient in other cases, though. References: Jammalamadaka, S. R., & Sengupta, A. (2001). Topics in circular statistics (Vol. 5). world scientific. The text was updated successfully, but these errors were encountered:
``` Add option for correcting for uniform marginals to circ_corrcc ```
``` 0c4ecd6 ```

# Codecov Report

Merging #64 into develop will decrease coverage by `0.17%`.
The diff coverage is `28.57%`.

```@@             Coverage Diff             @@
##           develop      #64      +/-   ##
===========================================
- Coverage     99.3%   99.13%   -0.18%
===========================================
Files           17       17
Lines         2889     2894       +5
Branches       483      484       +1
===========================================
Hits          2869     2869
- Misses           7       11       +4
- Partials        13       14       +1```
Impacted Files Coverage Δ
pingouin/circular.py `94.5% <28.57%> (-5.5%)` ⬇️

`Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`

approved these changes

### raphaelvallat left a comment

Thanks for the PR!

merged commit `3479e79` into raphaelvallat:develop Sep 3, 2019
2 of 4 checks passed