Flatpak

[sztomi]

I've started creating a flatpak package for Rio here: https://github.com/sztomi/flathub/tree/new-pr

It builds and runs, but I'm running into a problem: when it starts, it seems to run the shell that is in the sandbox instead of the system. I would think this is because of the sandboxing, but I used the wezterm flatpak as a starting point and wezterm doesn't seem to have that issue: https://github.com/flathub/org.wezfurlong.wezterm/blob/master/org.wezfurlong.wezterm.json

My guess is that rio is falling back to running sh due to some assumptions that don't hold when being ran in a container. Any ideas what might be happening here?

FWIW, this is how I build and run the above:

$ flatpak-builder --force-clean --user --install --repo=repo build-dir io.raphamorim.Rio.json
$ flatpak run io.raphamorim.Rio

---

Slightly unrelated, but it would be useful to include an icon that is smaller because flatpak refuses to export an icon over 512x512. So now I'm resorting to building imagemagick and resizing it.

[sztomi]

I think I can answer my question: wezterm is doing something special when running in flatpak: https://github.com/wez/wezterm/blob/99c9613966a73d5388344fd0df68d5977b493c7c/mux/src/domain.rs#L364

Is there interest in accepting a PR that adds this feature?

[raphamorim]

Thanks for the issue @sztomi

Is there interest in accepting a PR that adds this feature?

Yes, that would be great

The issue is exactly what you found, Rio can't retrieve $SHELL outside of sandbox.

https://github.com/wez/wezterm/blob/99c9613966a73d5388344fd0df68d5977b493c7c/mux/src/domain.rs#L394-L404

I created a branch with similar approach as wezterm for retrieve the SHELL would mind check it? https://github.com/raphamorim/rio/tree/flatpak

Slightly unrelated, but it would be useful to include an icon that is smaller because flatpak refuses to export an icon over 512x512. So now I'm resorting to building imagemagick and resizing it.

I assume it does not support svg icons right?

[sztomi]

I created a branch with similar approach as wezterm for retrieve the SHELL

It's not working for some reason (but looking at the code, it should). I can also run the same command and get the right shell and the .flatpak-info file exists.

I assume it does not support svg icons right?

That's a good question, it probably does (flatpak relies heavily on Freedesktop specifications) but there might be a requirement to also provide a non-vector icon. I'll look into it.

[raphamorim]

It's not working for some reason (but looking at the code, it should). I can also run the same command and get the right shell and the .flatpak-info file exists.

Did you have configured shell in config file? if it does exist it will override shell coming from environment. Wondering if the function is even being called in teletypewriter.

That's a good question, it probably does (flatpak relies heavily on Freedesktop specifications) but there might be a requirement to also provide a non-vector icon. I'll look into it.

Cool please let me know any finding otherwise I can for sure add an icon with 512x521 to the project.

[sztomi]

Did you have configured shell in config file?

No, I don't have anything configured, actually.

Cool please let me know any finding

Sounds like svg is fine: "Icons should be named with the application’s ID, be in either PNG or SVG format" https://docs.flatpak.org/en/latest/conventions.html#application-icons

[raphamorim]

No, I don't have anything configured, actually.

I see, just pushed few changes (realized get_pw_entry was being called twice and overwriting SHELL env). Could you check again? @sztomi

Sounds like svg is fine: "Icons should be named with the application’s ID, be in either PNG or SVG format" https://docs.flatpak.org/en/latest/conventions.html#application-icons

Cool! the svg path is https://github.com/raphamorim/rio/blob/main/misc/logo.svg

[sztomi]

The svg icon works and I made the change to use it (no more imagemagick! haha)

The latest changes on the flatpak branch lead to crash right after startup. I made a new branch that allows building from a local copy if you'd like to iterate on this: https://github.com/sztomi/flathub/tree/local

To get started:

$ flatpak install flathub org.flatpak.Builder
$ flatpak install flathub org.freedesktop.Platform//22.08 org.freedesktop.Sdk//22.08
$ flatpak install flathub org.freedesktop.Sdk.Extension.rust-stable/x86_64/22.08
$ alias flatpak-builder='flatpak run org.flatpak.Builder'
$ ln -s <your rio source dir> ./rio  # (or change the json file to point to the absolute path)

After each change,

$ flatpak-builder --force-clean --user --install build-dir io.raphamorim.Rio.json
$ flatpak run io.raphamorim.Rio  # or use the desktop launcher

(if not, that's fine, I'll try to fiddle with it)

Another question: does Rio support falling back to x11 if wayland is not available? I sort of assumed it did when built with both features, but I can't tell. Doing so is the preferred behavior for flatpak applications, as you can't really provide different versions (unless you package two different app IDs, but flathub might reject that).

[raphamorim]

Sorry about delay regarding this issue,

Another question: does Rio support falling back to x11 if wayland is not available? I sort of assumed it did when built with both features, but I can't tell. Doing so is the preferred behavior for flatpak applications, as you can't really provide different versions (unless you package two different app IDs, but flathub might reject that).

Doesn't have support for it natively, often rio is distributed with x11 or wayland label. Do you know how alacritty does? (if exist in flatpak)

[raphamorim]

The svg icon works and I made the change to use it (no more imagemagick! haha)

That's great news!

The latest changes on the flatpak branch lead to crash right after startup. I made a new branch that allows building from a local copy if you'd like to iterate on this: https://github.com/sztomi/flathub/tree/local

I will try it once I get my linux machine back lately have been switch between windows/macos due to work.

[sztomi]

Do you know how alacritty does? (if exist in flatpak)

No alacritty flatpak and from what I've seen in the repo, the maintainers have no interest in any packaging (they did state that they will accept patches to support packaging needs though). Wezterm on the other hand does this (they declare the flatpak supporting wayland with an X11 fallback).

[raphamorim]

Running locally and I am assuming it has some sort of fallback because it started for me with wayland instead of X11.

I didn't figured out how to point the flatpack-builder to the local directory

[sztomi]

how to point the flatpack-builder to the local directory

In my local branch, I changed the source from a tarball to a local dir here: https://github.com/sztomi/flathub/blob/local/io.raphamorim.Rio.json#L44

And I created a symlink from my local checkout to ./rio: ln -s ~/projects/rio ./rio. But you may also simply set an absolute path on that line, maybe that's even easier.

[raphamorim]

Coolio that works! pushed a change in latest main branch regarding flatpak, have not completely tested yet (feel free to test if you want) but will look it further.

[raphamorim]

Ok figured out why,

It runs and ask for the SHELL as is supposed to be and then crash because /usr/bin/zsh does not exist in the sandbox.