Cmd+w doesn't close the window

[tauil]

In MacOS the common behaviour would be when pressing Cmd+w to close the active window. At the moment, nothing happens.

[raphamorim]

Regarding this issue, Command + W is also used to close tabs.

As you mention Command + W works different in Rio macos now. In terminals it does works differently, like kitty/terminal.app closes the last tab and keep running, alacritty kills the process and etc.

I am not keen to add quit process for command+w, so even if this is implemented on macos, think will be better follow Terminal.App and Kitty behaviour

[tauil]

I didn't mean to kill the process but to kill the window. When I noticed the issue, I didn't have any tab open so nothing happened. I expected at least to kill the last existing window and leave the process running. iTerm2 behaves like that as well.

[raphamorim]

Gotcha! is this something you would have interest to work on @tauil ?

[tauil]

Yes! I just not used to Rust and the project yet so I might be much slower but I'm happy to try!

[tauil]

FYI: For transparency purposes, I'll stop working for now on this task as it's still too complicated for "Rust and Rio beginner"! Feel free if you want to work on it!

[clucasalcantara]

@raphamorim , cmd + w in fact close my tabs but the tab indicator keeps showing as they're still active 🤔

[raphamorim]

Hey @clucasalcantara thanks for the message!

this one is different than the original issue posted by @tauil . Would you mind create a different issue? Also which rio version and OS are you using?

[clucasalcantara]

Sure! latest rio and sonoma :D

…

On Fri, Nov 10, 2023 at 4:03 PM Raphael Amorim ***@***.***> wrote: Hey @clucasalcantara <https://github.com/clucasalcantara> thanks for the message! this one is different than the original issue posted by @tauil <https://github.com/tauil> . Would you mind create a different issue? Also which rio version and OS are you using? — Reply to this email directly, view it on GitHub <#296 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABUZMICNENAZULIBTVTFCB3YD26EJAVCNFSM6AAAAAA6DWSCMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBWGU3TONRVHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Caio Lucas Alcântara *Senior FrontEnd Engineer* +1 (236) 989-1739

[raphamorim]

@tauil change was introduced for native tabs only for now and it can be disabled by updating a config (navigation.macos-enable-close-last-tab). Only NativeTabs for now because those are the only one MacOS based, the rest of the navigation will require further testing in other platforms.

[tauil]

It doesn't seem to work for me. I just pulled the latest state of main (558e8ebbb3f0594d039d98a05d5416aab4db81ba) and re-built it.

I'm using the following config:

[navigation]
mode = "NativeTab"
macos-enable-close-last-tab = true