Cursor blinking is triggered by changes in inactive tabs

[hougesen]

Changes in other tabs should not cause the active tab to rerender since it makes the ui seem buggy.

Screencast.from.2024-01-28.16-23-43.webm

[hougesen]

Resizing the window also triggers a lot of rerenders.

Screencast.from.2024-01-28.16-40-10.webm

[raphamorim]

Good findings, yes those behaviors should be fixed. Now cursor can come either from terminal and state, most of times comes from state, but would be good move part of cursor rendering logic outside of state (state reflects in the current window rendering state).

[hougesen]

Are the changes required affected by #428?

I also noticed selecting text is a lot slower when blinking-cursor is turned on.

Turned off:

Screencast.from.2024-01-28.23-58-52.webm

Turned on:

Screencast.from.2024-01-28.23-59-41.webm

It is not a problem when using nvim or zellij, which I am guessing is because they handle cursor state themself (?).

Edit:

Adding a check for whether there is a selection eliminates the delay after first render.

rio/frontends/rioterm/src/screen/mod.rs

Lines 1254 to 1256 in 4ad69ff

	if self.state.has_blinking_enabled && has_blinking_enabled {
	self.context_manager.schedule_render(800);
	}

if self.state.has_blinking_enabled
	&& has_blinking_enabled
	&& self.selection_is_empty()
{
	self.context_manager.schedule_render(800);
}

I am not sure whether this is a desired long term solution, but it might make sense as a quick fix?

[raphamorim]

Are the changes required affected by #428?

No shouldn't be affected, #428 should touch mostly sugarloaf crate.

I also noticed selecting text is a lot slower when blinking-cursor is turned on.

Hmm, that would make sense because is stacking rendering and blinking (rendering) in the same time.

Adding a check for whether there is a selection eliminates the delay after first render.

I like the solution for now but shouldn't be the final fix (I guess) because could be that users would expect the cursor to blink if have selected text (?? not sure tbh).

Would you mind create a PR with those changes?

[hougesen]

Sure, coming up.

[hougesen]

Sadly this was not fixed as a by product of v0.1.0 😭

[raphamorim]

@hougesen is this happening still right? I've tried to reproduce locally without success. Is your configuration for cursor blinking true?

[raphamorim]

I've pushed a change to main, I think it should fix this issue (and also improve the overall experience for tabs) could you take a look later? 🙏

[hougesen]

As far as I can tell the issue has been fixed 🚀