The behavior of using a complete shell command and a shell command with parameters is inconsistent

[ahaoboy]

Similar to #531

This works

[shell]
program = "pwsh -nologo"
args = []

This doesn't

[shell]
program = "pwsh"
args = ["-nologo"]

If you start the msys2 command line with a command with parameters, it will exit rio and start a new windows window

# [shell]
# program = "C:\\msys64\\msys2_shell.cmd -defterm -here -no-start -mingw64  -use-full-path -shell fish"
# args =  []

[shell]
program = "C:\\msys64\\msys2_shell.cmd"
args = [
  "-defterm",
  "-here",
  "-no-start",
  "-ucrt64",
  "-use-full-path",
  "-shell",
  "fish",
]

I hope to be able to start the msys2 shell with parameters, so that the behavior will be consistent with the configuration of wt and vscode

[raphamorim]

thanks for the issue!

Hmmm, I believe this works on MacOS/Linux/BSD but not Windows and I found out why

rio/teletypewriter/src/windows/mod.rs

Lines 35 to 38 in 59aace1

	pub fn create_pty(
	shell: &str,
	_args: Vec<String>,
	working_directory: &Option<String>,

, apparently args doesn't do anything 😢 (we would need to concatenate with shell)

[raphamorim]

Fixed in ab480e9 🙏

Closing this issue for now. Next version you should be able to use args :D