LS command shows file list with unaligned columns

[jeffrbrito-nent]

[niuez]

It seems to be caused by rendering tab character \t. It can be fixed with replacing \t to single space .
I tried fixing it in create_sugar(), And it seems to work.

Sugar {
    content: if square.c == '\t' { ' ' } else { square.c },
    foreground_color,
    background_color,
    style,
    decoration: None,
}

There are problems...

• I don't know why it breaks when rendering \t...
• If this issue will be fixed by replacing, I don't know where in the code this should be corrected.

before

after

[raphamorim]

Good finding @niuez ,

Yes now it make sense why it is failing, looked even how alacritty does and they also replace for ' ' https://github.com/alacritty/alacritty/blob/4b92388396c6da783809c7ce511b5cf6be8a0624/alacritty/src/renderer/text/mod.rs#L150C1-L153

fn draw_cell(
        &mut self,
        mut cell: RenderableCell,
        glyph_cache: &mut GlyphCache,
        size_info: &SizeInfo,
    ) {
        // Get font key for cell.
        let font_key = match cell.flags & Flags::BOLD_ITALIC {
            Flags::BOLD_ITALIC => glyph_cache.bold_italic_key,
            Flags::ITALIC => glyph_cache.italic_key,
            Flags::BOLD => glyph_cache.bold_key,
            _ => glyph_cache.font_key,
        };

        // Ignore hidden cells and render tabs as spaces to prevent font issues.
        let hidden = cell.flags.contains(Flags::HIDDEN);
        if cell.character == '\t' || hidden {
            cell.character = ' ';
        }

Would you mind adding a fix for it? You can add this logic in create_sugar since is our translation to the renderer.

Also would be good add the check flag.contains(Flag::HIDDEN) (we have same flag logic)

[raphamorim]

Cannot reproduce anymore, closing this issue.