CMD+W open new tab but not new window occasionally

[raphamorim]

Discussed in #745

^{Originally posted by hilaolu October 30, 2024}
I am using MacOS and rio 0.1.17. Pressing CMD+W sometimes open a new tab on current focus but not a window. The frequency is quite low and the condition to reproduce is elusive. I try many times but only confirm that it happen in 0.1.17 and branch main, without finding any clues. Both CollapsedTab and NativeTab has the problem. Is it a feature and work as expected?

[hilaolu]

Thanks.
I try really hard but fail to reproduce. The chance is extremely low.

[hilaolu]

Appreciate 0.2.0. May I ask if this is fixed in 0.2.0?

[raphamorim]

Not yet, sorry about that. I ended up cutting the release ealier

[hilaolu]

Never mind. Looking forward to 0.2.1.

[hilaolu]

hi, any update on this bug?

[raphamorim]

Is this still happening (0.2.2)?

I couldn't repro in a while

[hilaolu]

I am on 0.2.2. It still happens.

[hilaolu]

I will try 0.2.3 first

[raphamorim]

Okey please lemme know 🙏

[hilaolu]

It still repro. I am on macOS v12.

[hilaolu]

Ok, I may figured out the cause and give a solution.

Here are the debug code to tell what happend.

Step to reproduce.

1.Create several windows.
2.Close the oldest window.
3.Create a new window.

The tab_id of new window is simply allocated by the total number of all existing windows, which collisions with the newest one. Thus, the new window with collision tab_id actually becomes a new tab.

All windows should be allocated a unique tab_id.