Repository navigation
Add audible & visual bell support - #1284
Merged
Merged
Conversation
ranisalt
commented
Aug 22, 2025
roziscoding
approved these changes
Aug 25, 2025
ranisalt
marked this pull request as ready for review
August 25, 2025 21:32
Contributor
Author
|
It is working on my Linux and my Mac machines, but I don't have Windows to test |
raphamorim
reviewed
Aug 26, 2025
raphamorim
reviewed
Aug 26, 2025
raphamorim
reviewed
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for a visual bell feature in the terminal, allowing the screen to briefly flash when a bell event occurs (if enabled in configuration).
Bellconfiguration struct toConfig, with a default value and deserialization support, allowing users to enable or disable the visual bell (rio-backend/src/config/mod.rs). [1] [2] [3] [4]frontends/rioterm/src/application.rs,frontends/rioterm/src/constants.rs). [1] [2]SugarloafUI library to support rendering a single overlay quad for the visual bell, including state management and render pass logic to ensure the overlay appears above all other content (sugarloaf/src/components/quad/mod.rs,sugarloaf/src/sugarloaf.rs,sugarloaf/src/sugarloaf/state.rs). [1] [2] [3] [4] [5] [6] [7]I plan to work on audible bell in a future PR, at least for Linux, adding new configuration options to the
[bell]section.