fix: remove duplicate kitty backspace keybinds - #375
Merged
raphamorim merged 1 commit intoDec 10, 2023
Conversation
raphamorim
approved these changes
Dec 10, 2023
raphamorim
left a comment
Owner
There was a problem hiding this comment.
Good finding! I forgot to remove it when porting kitty keyboard to config.
Tested and looks good 👌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deleted keybindings were duplicates of
rio/frontends/cross-winit/src/screen/bindings/mod.rs
Lines 742 to 744 in 208e913
After deleting the lines I no longer had any issues with backspace deleting 2 characters when Kitty protocol is turned on (#344).
Before with Kitty

false:Before with Kitty

true:After with Kitty
false:After with Kitty
true: