Skip to content

fix: remove duplicate kitty backspace keybinds - #375

Merged
raphamorim merged 1 commit into
raphamorim:mainfrom
hougesen:fix/remove-duplicate-kitty-keybinds
Dec 10, 2023
Merged

fix: remove duplicate kitty backspace keybinds#375
raphamorim merged 1 commit into
raphamorim:mainfrom
hougesen:fix/remove-duplicate-kitty-keybinds

Conversation

@hougesen

Copy link
Copy Markdown
Contributor

The deleted keybindings were duplicates of

Key::Named(Backspace), ~BindingMode::VI, ~BindingMode::ALL_KEYS_AS_ESC; Action::Esc("\x7f".into());
Key::Named(Backspace), ModifiersState::ALT, ~BindingMode::VI, ~BindingMode::ALL_KEYS_AS_ESC; Action::Esc("\x1b\x7f".into());
Key::Named(Backspace), ModifiersState::SHIFT, ~BindingMode::VI, ~BindingMode::ALL_KEYS_AS_ESC; Action::Esc("\x7f".into());
with the only difference between them being the spaces.

After deleting the lines I no longer had any issues with backspace deleting 2 characters when Kitty protocol is turned on (#344).

Before with Kitty false:
Before with Kitty false

Before with Kitty true:
Before with Kitty true

After with Kitty false:

After with Kitty false

After with Kitty true:

After with Kitty true

@raphamorim raphamorim left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good finding! I forgot to remove it when porting kitty keyboard to config.
Tested and looks good 👌

@raphamorim
raphamorim merged commit 539fda5 into raphamorim:main Dec 10, 2023
@hougesen
hougesen deleted the fix/remove-duplicate-kitty-keybinds branch December 10, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants