Skip to content

Fix hex size validation and add test cases for RGBA hex conversion - #696

Merged
raphamorim merged 3 commits into
raphamorim:mainfrom
bio:fix_hex_validation
Oct 6, 2024
Merged

raphamorim merged 3 commits into
raphamorim:mainfrom
bio:fix_hex_validation

Conversation

@bio

@bio bio commented Oct 6, 2024 •

Copy link
Copy Markdown
Contributor
  • Fixed regex that checks hex size.
  • Added a test case to verify conversion of RGBA hex colors (for example, #15151580).

);
}

#[test]

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! thank you for the PR @bio , could add another test using #06a49b99?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raphamorim sure, I added an additional test case.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@raphamorim
raphamorim merged commit 31af2ef into raphamorim:main Oct 6, 2024
@bio
bio deleted the fix_hex_validation branch October 6, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants