Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aux and post modules should have actions instead of targets #12125

Open
wvu-r7 opened this issue Jul 24, 2019 · 5 comments

Comments

@wvu-r7
Copy link
Contributor

commented Jul 24, 2019

Targets are supported by exploit and evasion modules.

wvu@kharak:/rapid7/metasploit-framework:master$ git grep -l 'Targets.*=>' modules/{auxiliary,post}
modules/auxiliary/admin/http/pfadmin_set_protected_alias.rb
modules/auxiliary/admin/http/scadabr_credential_dump.rb
modules/auxiliary/admin/http/telpho10_credential_dump.rb
modules/auxiliary/admin/http/typo3_news_module_sqli.rb
modules/auxiliary/admin/mssql/mssql_findandsampledata.rb
modules/auxiliary/admin/mssql/mssql_idf.rb
modules/auxiliary/admin/mssql/mssql_ntlm_stealer_sqli.rb
modules/auxiliary/gather/ie_sandbox_findfiles.rb
modules/auxiliary/gather/ms14_052_xmldom.rb
modules/auxiliary/gather/safari_file_url_navigation.rb
modules/auxiliary/scanner/http/iis_shortname_scanner.rb
modules/auxiliary/scanner/http/wp_arbitrary_file_deletion.rb
modules/auxiliary/scanner/ssh/apache_karaf_command_execution.rb
modules/post/linux/dos/xen_420_dos.rb
modules/post/linux/manage/sshkey_persistence.rb
modules/post/multi/escalate/metasploit_pcaplog.rb
modules/post/osx/gather/apfs_encrypted_volume_passwd.rb
modules/post/windows/escalate/unmarshal_cmd_exec.rb
modules/post/windows/manage/powershell/build_net_code.rb
wvu@kharak:/rapid7/metasploit-framework:master$
@sempervictus

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

So long as nobody is mixing in exploit code depending on target into their aux module (strictly inline processing in the module itself), this shouldn't be too rough to undo, and would be a significant cleanup of a very user-visible sharp edge.

@wvu-r7

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

It should be an easy update. I've marked it newbie-friendly in case someone new wants to take it on. I know at least one person interested.

@hkerma

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2019

@wvu-r7 I think I can take this one ! Not sure to understand what the bug is right now, but I'll investigate that. Will come back to you if I got any question (or results) !

@wvu-r7

This comment has been minimized.

Copy link
Contributor Author

commented Jul 28, 2019

Sounds good!

@wvu-r7

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2019

And nice bike. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.