Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Likely regression in modules/exploits/windows/local/ms16_075_reflection_juicy.rb #12698

Open
bwatters-r7 opened this issue Dec 11, 2019 · 4 comments

Comments

@bwatters-r7
Copy link
Contributor

@bwatters-r7 bwatters-r7 commented Dec 11, 2019

So, I was grepping for examples to pull the build numbers from Windows versions, and came across this module:
modules/exploits/windows/local/ms16_075_reflection_juicy.rb

It used the regex
win10build = client.sys.config.sysinfo['OS'].match /Windows 10 \(Build (\d+)\)/

I made some changes to the way meterpreter reported the sysinfo value, and I believe this regex is now broken. I used build_num = sysinfo_value.match(/\w+\d+\w+(\d+)/)[0].to_i in my module, but as a regex expert could tell you, I'm no regex expert....

@wvu-r7 wvu-r7 added the bug label Dec 11, 2019
@wvu-r7

This comment has been minimized.

Copy link
Contributor

@wvu-r7 wvu-r7 commented Dec 11, 2019

Are you taking this on?

@bwatters-r7

This comment has been minimized.

Copy link
Contributor Author

@bwatters-r7 bwatters-r7 commented Dec 11, 2019

I had no definitive passion to, but I figured if I did not document it, I would forget. If you want to knock it out, feel free!

@wvu-r7

This comment has been minimized.

Copy link
Contributor

@wvu-r7 wvu-r7 commented Dec 11, 2019

I do not. We are in agreement. :)

@bwatters-r7

This comment has been minimized.

Copy link
Contributor Author

@bwatters-r7 bwatters-r7 commented Dec 11, 2019

I mean.... the regex that I think works is right there.... if someone were looking to make a first PR, this is a ctrl-c ctrl-v problem....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.