Set normalize uri on modules #1047

Merged
merged 5 commits into from Jan 7, 2013

Projects

None yet

4 participants

@ChrisJohnRiley
Contributor

This is a follow on from PULL 1045 (HDM)

I've implemented the normalize_uri() function on a number
of modules that I think HD overlooked... there are probably
more that I missed on my search as well.

Please only consider this after applying PULL 1045 as
it contains the required normalize_uri() function used

ChrisJohnRiley added some commits Nov 8, 2012
@ChrisJohnRiley ChrisJohnRiley Add normalize_uri to modules that may have
been missed by PULL 1045.

Please ensure PULL 1045 is in place prior to
looking at this (as it implements normalize_uri)

ref --> rapid7#1045
f88ec5c
@ChrisJohnRiley ChrisJohnRiley Formatting 0dd4f4d
@brandonprry brandonprry commented on an outdated diff Nov 11, 2012
...ary/scanner/http/apache_activemq_source_disclosure.rb
res = send_request_cgi({
- 'uri' => "/#{target_uri.to_s}",
@brandonprry
brandonprry Nov 11, 2012 Contributor

Looks like a regression here. target_uri.path vs "/#{target_uri.to_s}"

@ChrisJohnRiley
Contributor

Fixed a couple of instances where target_uri.to_s and target_uri.path were mixed

@todb
Contributor
todb commented Jan 7, 2013

Fixing this up today; ran into a couple merge problems, one ruby -c warning. All in all not that big of a deal, just needs another eyeball pass. Figure on landing in a couple hours unless something really horrible pops up.

@todb-r7 todb-r7 merged commit 9412060 into rapid7:master Jan 7, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment