From 566d540b87a2e3d82dce4640f01a95556d30168d Mon Sep 17 00:00:00 2001 From: William Vu Date: Thu, 4 Oct 2018 14:05:39 -0500 Subject: [PATCH 1/3] Add AUDIO_EFFECTS to distinguish from others --- lib/msf/core/constants.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/msf/core/constants.rb b/lib/msf/core/constants.rb index 26431ef6b2f3..a8b25b320d82 100644 --- a/lib/msf/core/constants.rb +++ b/lib/msf/core/constants.rb @@ -80,9 +80,11 @@ module Msf IOC_IN_LOGS = 'ioc-in-logs' # Module may cause account lockouts (likely due to brute-forcing) ACCOUNT_LOCKOUTS = 'account-lockouts' -# Module may show something on the screen (Example: a window pops up) +# Module may cause software to show something on the screen (Example: a window pops up) SCREEN_EFFECTS = 'screen-effects' -# Module may produce physical effects in hardware (Examples: light, sound, or heat) +# Module may cause software to output audio from the speakers (Example: the app plays music) +AUDIO_EFFECTS = 'audio-effects' +# Module may produce physical effects in hardware (Examples: LED or LCD changes or hardware beeps) PHYSICAL_EFFECTS = 'physical-effects' # From 9e512b0246c048ed2f8adfc452dbe7306873bfeb Mon Sep 17 00:00:00 2001 From: William Vu Date: Thu, 4 Oct 2018 14:20:26 -0500 Subject: [PATCH 2/3] Clarify {SCREEN,AUDIO,PHYSICAL}_EFFECTS --- lib/msf/core/constants.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/msf/core/constants.rb b/lib/msf/core/constants.rb index a8b25b320d82..4ef3cbb7ff98 100644 --- a/lib/msf/core/constants.rb +++ b/lib/msf/core/constants.rb @@ -80,11 +80,11 @@ module Msf IOC_IN_LOGS = 'ioc-in-logs' # Module may cause account lockouts (likely due to brute-forcing) ACCOUNT_LOCKOUTS = 'account-lockouts' -# Module may cause software to show something on the screen (Example: a window pops up) +# Module may show something on the screen (Example: a window pops up) SCREEN_EFFECTS = 'screen-effects' -# Module may cause software to output audio from the speakers (Example: the app plays music) +# Module may output audio from the speakers (Example: the app plays music) AUDIO_EFFECTS = 'audio-effects' -# Module may produce physical effects in hardware (Examples: LED or LCD changes or hardware beeps) +# Module may produce physical effects (Example: the device moves) PHYSICAL_EFFECTS = 'physical-effects' # From 6efadb5f2d1a160871eca3bf29d5fc28d9c3f1d4 Mon Sep 17 00:00:00 2001 From: William Vu Date: Fri, 5 Oct 2018 16:03:09 -0500 Subject: [PATCH 3/3] Further clarify {AUDIO,PHYSICAL}_EFFECTS --- lib/msf/core/constants.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/msf/core/constants.rb b/lib/msf/core/constants.rb index 4ef3cbb7ff98..cca6b564cb50 100644 --- a/lib/msf/core/constants.rb +++ b/lib/msf/core/constants.rb @@ -82,9 +82,9 @@ module Msf ACCOUNT_LOCKOUTS = 'account-lockouts' # Module may show something on the screen (Example: a window pops up) SCREEN_EFFECTS = 'screen-effects' -# Module may output audio from the speakers (Example: the app plays music) +# Module may cause a noise (Examples: audio output from the speakers or hardware beeps) AUDIO_EFFECTS = 'audio-effects' -# Module may produce physical effects (Example: the device moves) +# Module may produce physical effects (Examples: the device makes movement or flashes LEDs) PHYSICAL_EFFECTS = 'physical-effects' #