New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show the output of apktool if injection fails #10747

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
3 participants
@timwr
Contributor

timwr commented Oct 5, 2018

I can't actually reproduce the issue anymore, so it's difficult to test, but if apktool fails it's useful to see the error.

Verification

Sorry, no verification steps :trollface:

@wvu-r7 wvu-r7 self-assigned this Oct 5, 2018

@wvu-r7 wvu-r7 merged commit 08c196c into rapid7:master Oct 5, 2018

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

wvu-r7 added a commit that referenced this pull request Oct 5, 2018

@wvu-r7

This comment has been minimized.

Show comment
Hide comment
@wvu-r7

wvu-r7 Oct 5, 2018

Contributor

Release Notes

This prints an error message from apktool on failed APK injection.

Contributor

wvu-r7 commented Oct 5, 2018

Release Notes

This prints an error message from apktool on failed APK injection.

msjenkins-r7 added a commit that referenced this pull request Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment