New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improper use of the Ruby shovel operator (<<) #10749

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
1 participant
@wvu-r7
Contributor

wvu-r7 commented Oct 5, 2018

junk would be modified and returned, and we just want to return the concatenated string. Practically doesn't matter, but it's incorrect.

This was my first public module. I've been wanting to fix this since. I'm noticing it again now as I look for how I used Ret in a target.

Creating a PR because of how we're handling MSF4 vs. MSF5. :/

Fixes #2589.

Fix improper use of the Ruby shovel operator (<<)
junk would be modified and returned, and we just want to return the
concatenated string. Practically doesn't matter, but it's incorrect.

This was my first public module. I've been wanting to fix this since.
I'm noticing it again now as I look for how I used Ret in a target.

@wvu-r7 wvu-r7 added module bug labels Oct 5, 2018

@wvu-r7 wvu-r7 self-assigned this Oct 5, 2018

wvu-r7 added a commit to wvu-r7/metasploit-framework that referenced this pull request Oct 5, 2018

@wvu-r7 wvu-r7 merged commit d9cb052 into rapid7:master Oct 5, 2018

1 of 3 checks passed

Metasploit Automation - Sanity Test Execution Build triggered for merge commit.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details

msjenkins-r7 added a commit that referenced this pull request Oct 5, 2018

@wvu-r7 wvu-r7 deleted the wvu-r7:bug/beetel branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment