New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve check_snake_case_filename regex in msftidy (redux) #10754

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
3 participants
@wvu-r7
Contributor

wvu-r7 commented Oct 5, 2018

I should have rewritten the regex to begin with. There was no reason to shoehorn in zero-length assertions.

#10729, #10753

@wvu-r7 wvu-r7 added bug msftidy labels Oct 5, 2018

@wchen-r7 wchen-r7 changed the title from Stop being an idiot about the regex and rewrite it to Improve msftidy.rb regex for snake-case filenames Oct 5, 2018

@wchen-r7 wchen-r7 assigned bcook-r7 and unassigned busterb Oct 5, 2018

@wvu-r7 wvu-r7 changed the title from Improve msftidy.rb regex for snake-case filenames to Improve check_snake_case_filename regex in msftidy (redux) Oct 5, 2018

@wvu-r7 wvu-r7 assigned wvu-r7 and unassigned bcook-r7 Oct 5, 2018

Stop being an idiot about the regex and rewrite it
There was no reason to shoehorn in zero-length assertions.

@wvu-r7 wvu-r7 merged commit 2186322 into rapid7:master Oct 5, 2018

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

wvu-r7 added a commit that referenced this pull request Oct 5, 2018

msjenkins-r7 added a commit that referenced this pull request Oct 5, 2018

@wvu-r7 wvu-r7 deleted the wvu-r7:feature/namespace branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment